Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

Add a default retry parameter to all public methods #315

Closed

Description

@krisowski

All public storage method should have a default retry parametr defined so that clients don't have to explicitly use the @retry.Retry decorator to handle transient issues, like 503 error code.

The solution could look similar to the implementation in the google-cloud-bigquery where retry is implemented in every public method and it is set to DEFAULT_RETRY by default.

Activity

  1. added
    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
    and removed
    🚨This issue needs some love.
    triage meI really want to be triaged.
    on Nov 23, 2020
  2. HemangChothani commented on Nov 30, 2020

    @HemangChothani
    Contributor

    Almost all the public methods has retry parameter with default value, adding in the remaining methods and will expose the parameter for users.

    api_response = self._connection.api_request(
    method="POST",
    path="/b",
    query_params=query_params,
    data=properties,
    _target_object=bucket,
    timeout=timeout,
    retry=DEFAULT_RETRY,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

api: storageIssues related to the googleapis/python-storage API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions