Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

Unused variables in _PropertyMixin.update method #151

Closed
#152
Closed
Unused variables in _PropertyMixin.update method#151
#152
Assignees
HemangChothani
Labels
api: storageIssues related to the googleapis/python-storage API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Description

@HemangChothani
HemangChothani
opened on May 19, 2020

Here is the method definition:

python-storage/google/cloud/storage/_helpers.py

Lines 311 to 318 in 792b21f

def update(
self,
client=None,
timeout=_DEFAULT_TIMEOUT,
if_generation_match=None,
if_generation_not_match=None,
if_metageneration_match=None,
if_metageneration_not_match=None,

In the implementation if_generation_match and if_generation_not_match are missing.

python-storage/google/cloud/storage/_helpers.py

Lines 363 to 366 in 792b21f

_add_generation_match_parameters(
query_params,
if_metageneration_match=if_metageneration_match,
if_metageneration_not_match=if_metageneration_not_match,

./cc @frankyn

Activity

  1. HemangChothani
    self-assigned this
    on May 19, 2020
  2. product-auto-label
    added
    api: storageIssues related to the googleapis/python-storage API.
    on May 19, 2020

  3. frankyn commented on May 19, 2020

    @frankyn
    frankyn
    on May 19, 2020
    Contributor

    @IlyaFaer, looks like I missed this during review. Thanks @HemangChothani for the catch!

  4. IlyaFaer commented on May 19, 2020

    @IlyaFaer
    IlyaFaer
    on May 19, 2020

    @frankyn, well, we all missed it. In docs we have only two metageneration* args for Bucket.update() and all four args for Blob.update(). Both are delegating to _PropertyMixin.update(). First I've added meta* for Bucket.update(). And then two others for Blob.update(), but forgot to add them into _add_generation_match_parameters() call.

  5. yoshi-automation
    added
    triage meI really want to be triaged.
    on May 20, 2020
  6. HemangChothani
    added
    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    and removed
    triage meI really want to be triaged.
    on May 20, 2020
  7. frankyn
    closed this as completedin #152on May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: storageIssues related to the googleapis/python-storage API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions