use converted expiration parameter for signed_query_params to generate_signed_url_v2 #105

Activity

1. HemangChothani

   added

   api: storageIssues related to the googleapis/python-storage API.Issues related to the googleapis/python-storage API.

   type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

   priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.

   on Apr 13, 2020
2. HemangChothani

   self-assigned this

   on Apr 13, 2020
3. frankyn commented on Apr 13, 2020

   

   frankyn

   on Apr 13, 2020

   Contributor

   More actions

   Should be number of seconds since epoch instead of a strict conversion from int to str type: https://cloud.google.com/storage/docs/access-control/signed-urls-v2

   Could you send a PR to fix this @HemangChothani?
4. HemangChothani commented on Apr 14, 2020

   

   HemangChothani

   on Apr 14, 2020

   ContributorAuthor

   More actions

   @frankyn Yes, for sure.
5. gcf-merge-on-green

   closed this as completedin #106on Apr 16, 2020
6. gcf-merge-on-green

   added a commit that references this issue on Apr 16, 2020

   fix(storage): remove expiration strict conversion (#106)

   ...

   This issue will close once commit 9550dad is merged into the 'main' branch.

   9550dad
7. cojenco

   added 2 commits that reference this issue on Oct 13, 2021

   fix(storage): remove expiration strict conversion (googleapis#106)

   ...

   This issue will close once commit 3bd5bac is merged into the 'main' branch.

   3bd5bac

   fix(storage): remove expiration strict conversion (googleapis#106)

   ...

   This issue will close once commit 0702055 is merged into the 'main' branch.

   0702055