[tseaver]

Closes #390.

[larkee]

This change likely wouldn't do anything. create_instance already blocks until the instance is created via op.result(120). I think the actual fix would be to update the pytest.fixture decorator to something similar to the test_snippets setup:
https://github.com/googleapis/python-spanner/blob/master/samples/samples/snippets_test.py#L61-L77

[tseaver]

@larkee The failure in the sample test (see #390) occurs here: I've certainly seen other cases where an LRO succeeds, but subsequent GET requests fail due to eventual consistency.

I think the actual fix would be to update the pytest.fixture decorator to something similar to the test_snippets setup.

The use of fixtures in that module is actually a little wonky: very few of the testcases declare their dependencies, and in fact they can't be run separately, because they rely on other testcases having run first, as I found out when trying to debug one of the failing samples last week.

$ git grep "def test" samples/samples/snippets_test.py
samples/samples/snippets_test.py:def test_create_instance(spanner_instance):
samples/samples/snippets_test.py:def test_create_instance_with_processing_units(capsys):
samples/samples/snippets_test.py:def test_create_database(database):
samples/samples/snippets_test.py:def test_create_database_with_encryption_config(capsys, spanner_instance):
samples/samples/snippets_test.py:def test_insert_data(capsys):
samples/samples/snippets_test.py:def test_delete_data(capsys):
samples/samples/snippets_test.py:def test_query_data(capsys):
samples/samples/snippets_test.py:def test_add_column(capsys):
samples/samples/snippets_test.py:def test_read_data(capsys):
samples/samples/snippets_test.py:def test_update_data(capsys):
samples/samples/snippets_test.py:def test_read_stale_data(capsys):
samples/samples/snippets_test.py:def test_read_write_transaction(capsys):
samples/samples/snippets_test.py:def test_query_data_with_new_column(capsys):
samples/samples/snippets_test.py:def test_add_index(capsys):
samples/samples/snippets_test.py:def test_query_data_with_index(capsys):
samples/samples/snippets_test.py:def test_read_data_with_index(capsys):
samples/samples/snippets_test.py:def test_add_storing_index(capsys):
samples/samples/snippets_test.py:def test_read_data_with_storing_index(capsys):
samples/samples/snippets_test.py:def test_read_only_transaction(capsys):
samples/samples/snippets_test.py:def test_add_timestamp_column(capsys):
samples/samples/snippets_test.py:def test_update_data_with_timestamp(capsys):
samples/samples/snippets_test.py:def test_query_data_with_timestamp(capsys):
samples/samples/snippets_test.py:def test_create_table_with_timestamp(capsys):
samples/samples/snippets_test.py:def test_insert_data_with_timestamp(capsys):
samples/samples/snippets_test.py:def test_write_struct_data(capsys):
samples/samples/snippets_test.py:def test_query_with_struct(capsys):
samples/samples/snippets_test.py:def test_query_with_array_of_struct(capsys):
samples/samples/snippets_test.py:def test_query_struct_field(capsys):
samples/samples/snippets_test.py:def test_query_nested_struct_field(capsys):
samples/samples/snippets_test.py:def test_insert_data_with_dml(capsys):
samples/samples/snippets_test.py:def test_log_commit_stats(capsys):
samples/samples/snippets_test.py:def test_update_data_with_dml(capsys):
samples/samples/snippets_test.py:def test_delete_data_with_dml(capsys):
samples/samples/snippets_test.py:def test_update_data_with_dml_timestamp(capsys):
samples/samples/snippets_test.py:def test_dml_write_read_transaction(capsys):
samples/samples/snippets_test.py:def test_update_data_with_dml_struct(capsys):
samples/samples/snippets_test.py:def test_insert_with_dml(capsys):
samples/samples/snippets_test.py:def test_query_data_with_parameter(capsys):
samples/samples/snippets_test.py:def test_write_with_dml_transaction(capsys):
samples/samples/snippets_test.py:def test_create_table_with_datatypes(capsys):
samples/samples/snippets_test.py:def test_insert_datatypes_data(capsys):
samples/samples/snippets_test.py:def test_query_data_with_array(capsys):
samples/samples/snippets_test.py:def test_query_data_with_bool(capsys):
samples/samples/snippets_test.py:def test_query_data_with_bytes(capsys):
samples/samples/snippets_test.py:def test_query_data_with_date(capsys):
samples/samples/snippets_test.py:def test_query_data_with_float(capsys):
samples/samples/snippets_test.py:def test_query_data_with_int(capsys):
samples/samples/snippets_test.py:def test_query_data_with_string(capsys):
samples/samples/snippets_test.py:def test_add_numeric_column(capsys):
samples/samples/snippets_test.py:def test_update_data_with_numeric(capsys):
samples/samples/snippets_test.py:def test_query_data_with_numeric_parameter(capsys):
samples/samples/snippets_test.py:def test_query_data_with_timestamp_parameter(capsys):
samples/samples/snippets_test.py:def test_query_data_with_query_options(capsys):
samples/samples/snippets_test.py:def test_create_client_with_query_options(capsys):

Most of that is because one sample wants to show setup (e.g., creating the Venues table), and other samples depend on having that setup already done. We could chose to use the pytest-dependency plugin to handle that case.

[tseaver]

@larkee I've opened #423 to sketch out how refactoring the samples test-drivers to use shared fixtures would look.

[tseaver]

Superseded by #423.