Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

feat(spanner): add client_options to base class - #132

Merged
tseaver merged 3 commits into
googleapis:masterfrom
MaxxleLLC:spanner_issue_116
Aug 14, 2020
Merged

tseaver merged 3 commits into
googleapis:masterfrom
MaxxleLLC:spanner_issue_116

Conversation

@HemangChothani

Copy link
Copy Markdown
Contributor

Fixes #116 🦕

@HemangChothani
HemangChothani requested review from a team, larkee and tseaver August 10, 2020 13:57
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 10, 2020

@larkee larkee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor things

Comment thread tests/unit/test_client.py Resolved
Comment thread tests/unit/test_client.py Resolved
Comment thread setup.py Resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement new client options

4 participants