Skip to content
This repository was archived by the owner on Dec 31, 2023. It is now read-only.
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

Cannot resize to 0 instances #12

Closed
#92
Closed
Cannot resize to 0 instances#12
#92
Assignees
vam-google
Labels
🚨This issue needs some love.api: computeIssues related to the googleapis/python-compute API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Description

@igor-solomatov
igor-solomatov
opened on Feb 2, 2021

Hi All,

If target size of the region instance group is 0, resize fails with bad request, since ?size=0 parameter is removed

The following check should be if v is not None currently it is if v and 0 equals to False in Python.

python-compute/google/cloud/compute_v1/services/region_instance_group_managers/transports/rest.py

Line 1339 in 16e7294

"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v

Activity

  1. product-auto-label
    added
    api: computeIssues related to the googleapis/python-compute API.
    on Feb 2, 2021
  2. igor-solomatov
    added a commit that references this issue on Feb 2, 2021

    googleapis#12: fix incorrectly checked value of request parameters

    9ca3c2e
  3. busunkim96
    assigned
    yon-mg
    on Feb 2, 2021
  4. yoshi-automation
    added
    triage meI really want to be triaged.
    on Feb 3, 2021
  5. busunkim96
    added
    priority: p2Moderately-important priority. Fix may not be included in next release.
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    and removed
    triage meI really want to be triaged.
    on Feb 3, 2021
  6. yoshi-automation
    added
    🚨This issue needs some love.
    and removed
    🚨This issue needs some love.
    on May 5, 2021

  7. parthea commented on Jun 17, 2021

    @parthea
    parthea
    on Jun 17, 2021
    Contributor

    @yon-mg PTAL

  8. vchudnov-g
    assigned
    vam-google
    and unassigned
    yon-mg
    on Jul 14, 2021

  9. vchudnov-g commented on Jul 14, 2021

    @vchudnov-g
    vchudnov-g
    on Jul 14, 2021
    Contributor

    A fix for this is forthcoming

  10. yoshi-automation
    added
    🚨This issue needs some love.
    on Aug 2, 2021

  11. busunkim96 commented on Aug 2, 2021

    @busunkim96
    busunkim96
    on Aug 2, 2021
    Contributor

    @vchudnov-g Has this been addressed? (Just checking as the issue is now OOSLO)

  12. busunkim96 commented on Aug 5, 2021

    @busunkim96
    busunkim96
    on Aug 5, 2021
    Contributor

    Update: @vam-google confirmed a fix has landed in the generator. I am working on re-generating the library right now.

  13. busunkim96
    closed this as completedin #92on Aug 9, 2021
  14. busunkim96
    added a commit that references this issue on Aug 9, 2021

    fix!: uint64/int64 fields accept ints instead of strings (#92)

    4d673cf

  15. busunkim96 commented on Aug 9, 2021

    @busunkim96
    busunkim96
    on Aug 9, 2021
    Contributor

    This should be fixed in the latest release google-cloud-compute==0.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.api: computeIssues related to the googleapis/python-compute API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions