feat: add type hints to methods #157

Activity

1. product-auto-label

   added

   api: bigqueryIssues related to the googleapis/python-bigquery API.Issues related to the googleapis/python-bigquery API.

   on Jul 7, 2020
2. meredithslota

   added

   type: docsImprovement to the documentation for an API.Improvement to the documentation for an API.

   on Jul 7, 2020
3. HemangChothani

   self-assigned this

   on Jul 8, 2020
4. HemangChothani commented on Jul 8, 2020

   

   HemangChothani

   on Jul 8, 2020

   Contributor

   More actions

   @darwinyip Description of the following statements:

    table = bigquery.Table(table_id, schema=schema)   
   # This statement creates a table class object locally which you need pass to `create_table` method to create your table 
   
   table = client.create_table(table)
   # This statement sent a request to the server to create a table in BigQuery database and return the table object with it's properties and information
   
   Example:
   table.created   # it gives the datetime of table creation
   table.etag  # gives the Etag of table
   table.num_rows  # gives the number of rows in table
   table.full_table_id  # full id of table including project and dataset.
   
5. HemangChothani commented on Aug 19, 2020

   

   HemangChothani

   on Aug 19, 2020

   Contributor

   More actions

   @darwinyip Did above explanation helped you?
6. darwinyip commented on Aug 19, 2020

   

   darwinyip

   on Aug 19, 2020

   Author

   More actions

   @HemangChothani Yes it did. Thank you. However main issue I am raising is the lack of documentation around it.
7. HemangChothani commented on Aug 24, 2020

   

   HemangChothani

   on Aug 24, 2020

   Last edited by HemangChothani

   Contributor

   More actions

   @darwinyip Is you concern related to type hints, types to method params.
8. tswast

   changed the title [-]Documentation on return types[/-] [+]feat: add type hints to methods[/+] on Dec 9, 2020
9. HemangChothani commented on Dec 18, 2020

   

   HemangChothani

   on Dec 18, 2020

   Last edited by HemangChothani

   Contributor

   More actions

   Should i mention return type of all the public methods of all the classes?

   Edit: Should we include pytype nox.py file to check type hints and return type as included in firestore
10. plamut

    closed this as completedin #613on Apr 23, 2021