This repository was archived by the owner on May 16, 2026. It is now read-only.
Repository navigation
Solve issue 43, Fix default dataset - #44
Merged
Merged
Conversation
Author: alonme <alon.menczer@gmail.com>
tswast
reviewed
Dec 3, 2019
| credentials.project_id, self.dataset_id) | ||
|
|
||
| return bigquery.Client( | ||
| project=credentials.project_id, |
Contributor
There was a problem hiding this comment.
Note: there are some kinds of credentials that don't have a project_id property. e.g. if someone uses gcloud application-default login.
Edit: Looks like it's not relevant, as this is only called with service account credentials.
tswast
reviewed
Dec 4, 2019
tswast
approved these changes
Dec 4, 2019
Contributor
Author
|
@mxmzdlv Can you kindly merge and deploy a new version for this bug fix? |
Contributor
|
Thanks for fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Author: alonme alon.menczer@gmail.com