Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

2.11.0 version breaks retrocompatibility with python-bigquery 1.x branch #477

Closed as not planned

Description

@drake-mer

Environment details

  • OS type and version:
  • Python version: python --version
  • pip version: pip --version
  • google-api-core version: 2.11.0

Steps to reproduce

Run a bigquery job with python-bigquery v 1.28.2 and google-api-core 2.11.0

Stack trace

TypeError: QueryJob._blocking_poll() got an unexpected keyword argument 'retry'
[...]
    results = query_job.result()  # Waits for job to complete.
  File "/usr/local/lib/python3.10/site-packages/google/cloud/bigquery/job.py", line 3230, in result
    super(QueryJob, self).result(retry=retry, timeout=timeout)
  File "/usr/local/lib/python3.10/site-packages/google/cloud/bigquery/job.py", line 835, in result
    return super(_AsyncJob, self).result(timeout=timeout)
  File "/usr/local/lib/python3.10/site-packages/google/api_core/future/polling.py", line 256, in result
    self._blocking_poll(timeout=timeout, retry=retry, polling=polling)

Activity

  1. tswast commented on Dec 14, 2022

    @tswast
    Contributor

    I suspect a regression with the functionality related to these PRs:

    Note that we had to be very careful in #9 to make sure we only passed retry back to _blocking_poll if an explicit value for retry was passed in. That way that versions of google-cloud-bigquery that don't have support for that retry value won't fail.

  2. tswast commented on Dec 14, 2022

    @tswast
    Contributor

    There were unit tests to cover this, so I'm not sure what happened.

  3. tswast commented on Dec 14, 2022

    @tswast
    Contributor

    I see what happened:

    def _blocking_poll(self, timeout=None, retry=None, polling=None):

    The test intended to not have a retry argument. Now has a retry argument.

    Edit: Likewise, in addition to _blocking_poll similar logic to avoid passing in an unsupported retry argument was removed for done.

  4. vam-google commented on Jan 9, 2023

    @vam-google
    Contributor

    This bug should be fixed in python-bigquery instead (please just make it handle non-numeric default value) #479

  5. cristianmtr commented on Apr 18, 2023

    @cristianmtr

    I'm also facing this issue. Are there any workarounds?

  6. removed their assignment
    on Apr 27, 2023
  7. added
    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.
    on May 16, 2023
  8. vchudnov-g commented on Oct 24, 2023

    @vchudnov-g
    Contributor

    Support for the BigQuery v1 branch is ending, as per this comment. Note that the Google OSS Library Breaking Change Policy only provides for a 12-month support window after a new major version of a library is released, and we're beyond that window for BigQuery v1. We encourage you to upgrade to the latest versions of our libraries, and let us know of any problems you encounter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions