Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

Noxfile is not updated with Sphinx version pin #219

Closed

Description

@dandhlee

is there a plan to use templated noxfile.py for this repo? If so, please help make it use the templated version, otherwise I'll manually update the noxfile content.

Activity

  1. added
    type: processA process-related concern. May include testing, release, or the like.
    priority: p2Moderately-important priority. Fix may not be included in next release.
    on Jun 24, 2021
  2. dandhlee commented on Jul 7, 2021

    @dandhlee
    ContributorAuthor

    Not quite yet fixed as per Tres' comment in #224.

  3. tseaver commented on Jul 7, 2021

    @tseaver
    Contributor

    noxfile.py in this repo differs from the templated version on several counts:

    • It doesn't exclude docfx from the default session list.
    • It has a pytypes session.
    • It does not have a system session.
    • It has an additional unit_grpc_gcp session which runs unit tests with grpcio-gcp installed.
    • It uses flake8-import-order in its lint session.
  4. dandhlee commented on Jul 7, 2021

    @dandhlee
    ContributorAuthor

    I see. It sounds like noxfile.py file in this repo has a lot more stuff that needs to stay, if that's the case I'm happy to come back and manually update when needed for docfx. However, for other parts of noxfile.py, is there a way we're keeping things up to date with the template?

  5. tseaver commented on Jul 7, 2021

    @tseaver
    Contributor

    is there a way we're keeping things up to date with the template?

    Nope. The pain threshhold for re-injecting the needed changes using s.replace() is pretty high, especially because the template gets changed for "arbitrary" reasons, which tends to break such replacements, proportionally to their number / complexity.

  6. dandhlee commented on Jul 7, 2021

    @dandhlee
    ContributorAuthor

    For that much stuff we need to add for this repo, it does seem fairly obnoxious to be adding multiple lines of s.replace(), I think it's fine to move on with just manually updating noxfile.py on this repo then 👍

    Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.type: processA process-related concern. May include testing, release, or the like.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions