You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 23, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Feb 23, 2026. It is now read-only.
Noxfile is not updated with Sphinx version pin #219
is there a plan to use templated noxfile.py for this repo? If so, please help make it use the templated version, otherwise I'll manually update the noxfile content.
I see. It sounds like noxfile.py file in this repo has a lot more stuff that needs to stay, if that's the case I'm happy to come back and manually update when needed for docfx. However, for other parts of noxfile.py, is there a way we're keeping things up to date with the template?
is there a way we're keeping things up to date with the template?
Nope. The pain threshhold for re-injecting the needed changes using s.replace() is pretty high, especially because the template gets changed for "arbitrary" reasons, which tends to break such replacements, proportionally to their number / complexity.
For that much stuff we need to add for this repo, it does seem fairly obnoxious to be adding multiple lines of s.replace(), I think it's fine to move on with just manually updating noxfile.py on this repo then 👍
Activity
dandhlee commentedon Jul 7, 2021
Not quite yet fixed as per Tres' comment in #224.
tseaver commentedon Jul 7, 2021
noxfile.pyin this repo differs from the templated version on several counts:docfxfrom the default session list.pytypessession.systemsession.unit_grpc_gcpsession which runs unit tests withgrpcio-gcpinstalled.flake8-import-orderin its lint session.dandhlee commentedon Jul 7, 2021
I see. It sounds like
noxfile.pyfile in this repo has a lot more stuff that needs to stay, if that's the case I'm happy to come back and manually update when needed for docfx. However, for other parts ofnoxfile.py, is there a way we're keeping things up to date with the template?tseaver commentedon Jul 7, 2021
Nope. The pain threshhold for re-injecting the needed changes using
s.replace()is pretty high, especially because the template gets changed for "arbitrary" reasons, which tends to break such replacements, proportionally to their number / complexity.dandhlee commentedon Jul 7, 2021
For that much stuff we need to add for this repo, it does seem fairly obnoxious to be adding multiple lines of
s.replace(), I think it's fine to move on with just manually updatingnoxfile.pyon this repo then 👍Thank you!
chore: update reminder for sphinx version update on other repositories (