Skip to content
This repository was archived by the owner on Aug 30, 2026. It is now read-only.

Trying Guava JRE flavor to see build failure - #959

Closed
suztomo wants to merge 2 commits into
masterfrom
default_method
Closed

suztomo wants to merge 2 commits into
masterfrom
default_method

Conversation

@suztomo

@suztomo suztomo commented Mar 15, 2021 •

Copy link
Copy Markdown
Member

Background: I'm checking repositories of the libraries in LTS can be built with other libraries in the same LTS. During preparation, I found that I cannot build this repository (java-spanner) with Guava's JRE flavor (which is to be added in LTS).

@suztomo
suztomo requested review from a team March 15, 2021 23:42
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 15, 2021
@product-auto-label product-auto-label Bot added the api: spanner Issues related to the googleapis/java-spanner API. label Mar 15, 2021
@suztomo
suztomo marked this pull request as draft March 15, 2021 23:42
@suztomo

suztomo commented Mar 16, 2021

Copy link
Copy Markdown
Member Author

It fails somehow https://github.com/googleapis/java-spanner/pull/959/checks?check_run_id=2117302006

Error:  COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/IsRetryableInternalError.java:[24,8] 
com.google.cloud.spanner.IsRetryableInternalError is not abstract and does not override abstract method 
test(java.lang.Throwable) in java.util.function.Predicate
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/IsSslHandshakeException.java:[22,8] 
com.google.cloud.spanner.IsSslHandshakeException is not abstract and does not override abstract method 
test(java.lang.Throwable) in java.util.function.Predicate

But this does not make sense to me because Guava's Predicate has default test method.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant