Skip to content

Pubsub: Raise ValueError for message bytesize too big for batch - #4872

Merged
theacodes merged 2 commits into
googleapis:masterfrom
chemelnucfin:pubsub_raise_error_max_bytes
Feb 13, 2018
Merged

Pubsub: Raise ValueError for message bytesize too big for batch#4872
theacodes merged 2 commits into
googleapis:masterfrom
chemelnucfin:pubsub_raise_error_max_bytes

Conversation

@chemelnucfin

@chemelnucfin chemelnucfin commented Feb 12, 2018 •
edited by dpebot
Loading

Copy link
Copy Markdown
Contributor

No description provided.

@chemelnucfin chemelnucfin added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: pubsub Issues related to the Pub/Sub API. labels Feb 12, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 12, 2018
theacodes
theacodes suggested changes Feb 12, 2018
View reviewed changes
Comment thread pubsub/google/cloud/pubsub_v1/publisher/client.py Outdated
message = types.PubsubMessage(data=data, attributes=attrs)
if message.ByteSize() > self.batch_settings.max_bytes:
raise ValueError('Message being published is too large for the '
'batch settings with max bytes {}.'.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread pubsub/tests/system.py Outdated
assert isinstance(result, six.string_types)


def test_publish_max_bytes(publisher, topic_path, cleanup):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

chemelnucfin
chemelnucfin commented Feb 12, 2018
View reviewed changes
Comment thread pubsub/tests/unit/pubsub_v1/publisher/test_publisher_client.py
client.publish(topic, 42)


def test_publish_data_too_large():

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@chemelnucfin

chemelnucfin commented Feb 12, 2018

Copy link
Copy Markdown
Contributor Author

@jonparrott PTAL, thanks.

@theacodes

theacodes commented Feb 12, 2018

Copy link
Copy Markdown
Contributor

@chemelnucfin the CI failure here seems unrelated, so feel free to merge - but, could you send a follow-up PR to fix that?

@chemelnucfin
chemelnucfin force-pushed the pubsub_raise_error_max_bytes branch from 7da9574 to b688939 Compare February 12, 2018 22:12
@chemelnucfin

chemelnucfin commented Feb 12, 2018

Copy link
Copy Markdown
Contributor Author

@dpebot merge on green

@dpebot

dpebot commented Feb 12, 2018

Copy link
Copy Markdown
Contributor

Okay! I'll merge when all statuses are green and all reviewers approve.

@dpebot dpebot added the automerge Merge the pull request once unit tests and other checks pass. label Feb 12, 2018
@dpebot dpebot assigned dpebot and unassigned theacodes and chemelnucfin Feb 12, 2018
@theacodes
theacodes merged commit 56d1652 into googleapis:master Feb 13, 2018
@chemelnucfin chemelnucfin mentioned this pull request Feb 13, 2018
Closed
@tseaver tseaver mentioned this pull request May 20, 2019
Closed
parthea pushed a commit that referenced this pull request Mar 2, 2026
@chemelnucfin Jon Wayne Parrott
Raise ValueError when a message is too large for a batch (#4872)
4ce1c69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer
1 more reviewer
@theacodes theacodes theacodes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@dpebot dpebot

Labels

api: pubsub Issues related to the Pub/Sub API. automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chemelnucfin @theacodes @dpebot @googlebot