Repository navigation
Clarify 'user_project' semantics for API wrapper methods. - #4199
Merged
tseaver merged 1 commit intoOct 16, 2017
Merged
Conversation
Closes #4142. [ci skip]
googlebot
added
the
cla: yes
dhermes
approved these changes
Oct 16, 2017
dhermes
left a comment
dhermes
left a comment
Contributor
There was a problem hiding this comment.
LGTM (I assume user_project is a valid attr on all of the classes with annotated methods?)
Contributor
Author
|
Yes, it is defined on the bucket: blob and notification instances have read-only properties which "borrow" it from the bucket. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4142.
[ci skip]