Repository navigation
fix(bigquery): pass universe_domain to the BigQuery Storage client - #18783
Merged
Merged
Conversation
_ensure_bqstorage_client() created BigQueryReadClient without client_options, so in a non-default universe the Storage client pointed at bigquerystorage.googleapis.com while the BigQuery client used the configured universe. to_arrow(), to_dataframe() and DB-API reads through the Storage API sent requests to the wrong endpoint. Store the resolved universe on Client and pass it to the new Storage client when the caller gives no client_options.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request ensures that the BigQuery Storage client inherits the parent client's universe domain when initialized, preventing it from defaulting to googleapis.com when a custom universe domain is configured. It also adds corresponding unit tests to verify this behavior. There are no review comments, so I have no feedback to provide.
tswast
approved these changes
Oct 20, 2026
This was referenced Oct 20, 2026
Merged
ohmayr
pushed a commit
that referenced
this pull request
Oct 29, 2026
🤖 I have created a release *beep* *boop* --- ## [3.47.0](google-cloud-bigquery-v3.46.2...google-cloud-bigquery-v3.47.0) (2026-10-29) ### Features * **bigquery:** add column data policies to SchemaField ([#18710](#18710)) ([157efe4](157efe4)) * **bigquery:** add timestamp_precision for Arrow query results ([#18649](#18649)) ([a29d384](a29d384)) * **bigquery:** read Arrow results from explicit destinations ([#18654](#18654)) ([8ac01b9](8ac01b9)) * **bigquery:** share one BigQuery Storage client per Client ([#18652](#18652)) ([89cbc50](89cbc50)) * **bigquery:** skip job creation for ARROW query_and_wait results ([#18799](#18799)) ([ca24f26](ca24f26)) * **bigquery:** validate Arrow queries before sending them ([#18645](#18645)) ([1ac51ce](1ac51ce)) * support Python 3.15 ([8fceef4](8fceef4)) ### Bug Fixes * **bigquery:** apply max_results to the whole Arrow result ([#18651](#18651)) ([48c022c](48c022c)) * **bigquery:** keep the Arrow first page and wait without rows ([#18650](#18650)) ([4eb0e71](4eb0e71)) * **bigquery:** keep the Arrow schema for empty results ([#18655](#18655)) ([3ccf5ac](3ccf5ac)) * **bigquery:** pass universe_domain to the BigQuery Storage client ([#18783](#18783)) ([6ab4063](6ab4063)) * **bigquery:** raise when an Arrow batch arrives before its schema ([#18791](#18791)) ([7944a4c](7944a4c)) * **bigquery:** require bqstorage 2.43.0 ([#18780](#18780)) ([3cd40ce](3cd40ce)) * **bigquery:** send the same Arrow options on jobs.query and ReadRows ([#18646](#18646)) ([d7a2d27](d7a2d27)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Points the BigQuery Storage client at the same universe as the BigQuery client. Before,
_ensure_bqstorage_client()created it withoutclient_options, so in a non-default universeto_arrow(),to_dataframe()and DB-API reads went tobigquerystorage.googleapis.com.Client.client_options.client_optionsunchanged.