Skip to content

chore: regenerate google-cloud-storage - #16799

Closed
jskeet wants to merge 1 commit into
googleapis:mainfrom
jskeet:regenerate-storage
Closed

jskeet wants to merge 1 commit into
googleapis:mainfrom
jskeet:regenerate-storage

Conversation

@jskeet

@jskeet jskeet commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@jskeet
jskeet requested a review from parthea April 24, 2026 14:12
@jskeet
jskeet requested a review from a team as a code owner April 24, 2026 14:12

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors import statements across several files in the google-cloud-storage package, including combining imports from the same module and reordering them for consistency. I have no feedback to provide.

@parthea

parthea commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

I was able to get the Kokoro pre-release Tests to pass in #16803 . Someone from the GCS team will need to take a look at python-sdk-zb-system-test (gcs-aiml-clients-testing-101. The failure is Step #3 - "run-tests-and-delete-vm": ERROR: (gcloud.compute.ssh) FAILED_PRECONDITION: Login profile size exceeds 32 KiB. Delete profile values to make additional space.

I don't believe the cleanup-old-keys step is working

- name: "gcr.io/google.com/cloudsdktool/cloud-sdk"
id: "cleanup-old-keys"
entrypoint: "bash"
args:
- "-c"
- |
#!/bin/bash
set -e
echo "Fetching OS Login SSH keys..."
echo "Removing all keys."
echo "---------------------------------------------------------------------"
FINGERPRINTS_TO_DELETE=$$(gcloud compute os-login ssh-keys list \
--format="value(fingerprint)")
echo "Keys to delete: $$FINGERPRINTS_TO_DELETE"
if [ -z "$$FINGERPRINTS_TO_DELETE" ]; then
echo "No keys found to delete. Nothing to do."
exit 0
fi
while IFS= read -r FINGERPRINT; do
if [ -n "$$FINGERPRINT" ]; then
echo "Deleting key with fingerprint: $$FINGERPRINT"
gcloud compute os-login ssh-keys remove \
--key="$$FINGERPRINT" \
--quiet || true
fi
done <<< "$$FINGERPRINTS_TO_DELETE"
echo "---------------------------------------------------------------------"
echo "Cleanup complete."

Step #1 - "cleanup-old-keys": Keys to delete: 
Step #1 - "cleanup-old-keys": No keys found to delete. Nothing to do.

Since the check is broken, we can temporarily disable it, block releases and file a bug to follow up on it before we enable releases.

@jskeet

jskeet commented Apr 27, 2026

Copy link
Copy Markdown
Contributor Author

Closing in favor of #16803

@jskeet jskeet closed this Apr 27, 2026
parthea added a commit that referenced this pull request Apr 27, 2026
This PR
- Enables code generation for google-cloud-storage
- Formats handwritten files using `nox-s format`
- Disables presubmit `python-sdk-zb-system-test
(gcs-aiml-clients-testing-101) ` which is broken. See
#16487.
- Fixes the failing `Kokoro Pre-release Tests` seen in
#16799

Releases are already blocked for `google-cloud-storage`


https://github.com/googleapis/google-cloud-python/blob/81b7fad2bbc450a846c9769959a7c3a62ea844cb/.librarian/config.yaml#L22-L25

Closes #16799
@jskeet
jskeet deleted the regenerate-storage branch May 13, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants