Repository navigation
Update pin for 'googleapis-common-protos'. #8686
Description
From #8674.
Recent autogen changes have begun using features present only in googleapis-common-protos 1.6.0+, specifially the google.api.client package. E.g.:
$ git grep -l "google\/api\/client\.proto" | grep "\.proto$"
automl/google/cloud/automl_v1beta1/proto/prediction_service.proto
automl/google/cloud/automl_v1beta1/proto/service.proto
bigquery/google/cloud/bigquery_v2/proto/model.proto
bigquery_storage/google/cloud/bigquery_storage_v1beta1/proto/storage.proto
datacatalog/google/cloud/datacatalog_v1beta1/proto/datacatalog.proto
datalabeling/google/cloud/datalabeling_v1beta1/proto/data_labeling_service.proto
dlp/google/cloud/dlp_v2/proto/dlp.proto
irm/google/cloud/irm_v1alpha2/proto/incidents_service.proto
kms/google/cloud/kms_v1/proto/service.proto
language/google/cloud/language_v1/proto/language_service.proto
redis/google/cloud/redis_v1/proto/cloud_redis.proto
redis/google/cloud/redis_v1beta1/proto/cloud_redis.proto
talent/google/cloud/talent_v4beta1/proto/application_service.proto
talent/google/cloud/talent_v4beta1/proto/company_service.proto
talent/google/cloud/talent_v4beta1/proto/completion_service.proto
talent/google/cloud/talent_v4beta1/proto/event_service.proto
talent/google/cloud/talent_v4beta1/proto/job_service.proto
talent/google/cloud/talent_v4beta1/proto/profile_service.proto
talent/google/cloud/talent_v4beta1/proto/tenant_service.proto
translate/google/cloud/translate_v3beta1/proto/translation_service.proto
videointelligence/google/cloud/videointelligence_v1/proto/video_intelligence.protoThis "leakage" can break clients who are upgrading an existing virtualenv, because ce currently pin googleapis-common-protos >= 1.5.3, != 1.5.4, < 2.0dev in api_core/setup.py, and googleapis-common-protos >= 1.5.9, < 2.0.0dev in bigquery_storage/setup.py.
Steps to remediate:
- Update the pin of
googleapis-common-protosinapi_core/setup.py. (API Core / BigQuery Storage: Fix pins of 'googleapis-common-protos. #8688) - Remove the pin of
googleapis-common-protosinbigquery_storage/setup.py. (API Core / BigQuery Storage: Fix pins of 'googleapis-common-protos. #8688) - Release a new
1.14.0version ofgoogle-api-core. (Release api_core 1.14.0 #8700) - Update pins of
google-api-coreallgoogle-cloud-*packages to1.14.0. (Bump minimum version for google-api-core to 1.14.0. #8709)
Bump pins of google-cloud-core >= 1.0.3, < 2.0.0dev:
-
bigquery(BigQuery: Addclient_optionsto constructors for manual clients. #8999) -
bigtable(chore: pingoogle-cloud-core >= 1.0.3, < 2.0.0dev. #9445) -
datastore(Datastore: Addclient_optionsto constructors for manual clients. #9055) -
dns(chore: pingoogle-cloud-core >= 1.0.3, < 2.0.0dev. #9445) -
firestore(chore: pingoogle-cloud-core >= 1.0.3, < 2.0.0dev. #9445) -
logging(chore: pingoogle-cloud-core >= 1.0.3, < 2.0.0dev. #9445) -
runtimeconfig(chore: pingoogle-cloud-core >= 1.0.3, < 2.0.0dev. #9445) -
spanner(chore: pingoogle-cloud-core >= 1.0.3, < 2.0.0dev. #9445) -
storage(Storage: Addclient_optionsto constructors for manual clients. #9054) -
trace(chore: pingoogle-cloud-core >= 1.0.3, < 2.0.0dev. #9445) -
translate(Translate: Add client options to translate_v2. #8737)
Release the world (as of 2019-10-10):
- Release
bigquery(Release bigquery 1.19.0 #9168) - Release
datastore(chore(datastore): release 1.10.0 #9449) - Release
datalabeling(chore(datalabeling): release 0.3.0 #9443) - Release
grafeas(chore(grafeas): release 0.3.0 #9446) Releaseirm- Release
phishingprotection(chore(phishingprotection): release 0.2.0 #9452; chore(phishingprotection): release 0.2.0 #9447 was b0rked) - Release
resource_manager(chore(resource_manager): release 0.30.0 #9448) - Release
storage(chore(translate): release 1.7.0 #9421)
After merge of #9445:
- Release
bigtable(chore(bigtable): release 1.1.0 #9468) - Release
dns(chore(dns): release 0.31.0 #9469) - Release
firestore(chore(firestore): release 1.5.0 #9470) - Release
logging(chore(logging): release 1.14.0 #9471) - Release
runtimeconfig(chore(runtimeconfig): release 0.30.0 #9472) - Release
spanner(chore(spanner): release 1.11.0 #9473) - Release
trace(chore(trace): release 0.23.0 #9474)
After release of google-cloud-logging:
-
error_reporting: bumpgoogle-cloud-logging >= 1.14.0, < 2.0.0dev(chore(error_reporting): pin 'google-cloud-logging >= 1.14.0, < 2.0.0dev #9476) - Release
error_reporting(chore(error_reporting): release 0.33.0 #9515)
Metadata
Metadata
Assignees
Labels
Issues related to the AutoML API.Issues related to the BigQuery API.Issues related to the BigQuery Storage API.Issues related to the Bigtable API.Issues related to the Error Reporting API.Issues related to the Cloud Key Management Service API.Issues related to the Resource Manager API.Issues related to the Data Catalog API.Issues related to the AI Platform Data Labeling Service API.Issues related to the Sensitive Data Protection API.Issues related to the Cloud DNS API.Issues related to the Firestore API.Issues related to the Cloud Natural Language API API.Issues related to the Cloud Logging API.Issues related to the Phishing Protection API.Issues related to the Memorystore for Redis API.Issues related to the Cloud Runtime Config API API.Issues related to the Spanner API.Issues related to the Cloud Translation API API.Issues related to the Video Intelligence API API.A process-related concern. May include testing, release, or the like.
Activity
4 remaining items
busunkim96 commentedon Jul 19, 2019
@tseaver I'll have to do a "release the world" soonish to get client_options into the wild for the generated clients. Any things to watch out for when I make the release PRs?
tseaver commentedon Jul 19, 2019
@busunkim96 Maybe make them minor releases (rather than patch) due to the dependency bump? For the generated clients, you would be doing that anyway for a new feature.
Update pins of 'googleapis-common-protos. (#8688)
Update pins of 'googleapis-common-protos. (#8688)
Update pins of 'googleapis-common-protos. (#8688)