Storage: This doesn't match our existing project ID: hello-rightscale002 #4447

Activity

1. chemelnucfin

   added

   api: storageIssues related to the Cloud Storage API.Issues related to the Cloud Storage API.

   priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.

   on Nov 24, 2017
2. chemelnucfin

   changed the title [-]This doesn't match our existing project ID: hello-rightscale002[/-] [+]Storage: This doesn't match our existing project ID: hello-rightscale002[/+] on Nov 24, 2017
3. chemelnucfin commented on Nov 27, 2017

   

   chemelnucfin

   on Nov 27, 2017

   Contributor

   More actions

   I think the project id specifications have changed. I will try to find out more about what they should be and adjust the regex accordingly.
4. chemelnucfin

   added a commit that references this issue on Nov 28, 2017

   Closes googleapis#4447: Storage: Relax project id regex due to issue

   This issue will close once commit bab607d is merged into the 'master' branch.

   bab607d
5. chemelnucfin commented on Nov 28, 2017

   

   chemelnucfin

   on Nov 28, 2017

   Last edited by dhermes

   Contributor

   More actions

   Hi @papudesi, dhermes suggested a temporary fix while I try to find the actual project id. I will leave this issue open until I can find the actual requirements.

   import re
   
   from google.cloud.storage import notification
   
   
   notification._PROJECT_PATTERN = r'(?P<project>[a-z]+-[a-z]+\d+)'
   notification._TOPIC_REF_PATTERN = notification._TOPIC_REF_FMT.format(
       notification._PROJECT_PATTERN,
       notification._TOPIC_NAME_PATTERN)
   notification._TOPIC_REF_RE = re.compile(notification._TOPIC_REF_PATTERN)`
6. hrfuller commented on Dec 6, 2017

   

   hrfuller

   on Dec 6, 2017

   Last edited by hrfuller

   Contributor

   More actions

   Also running into this with an existing project id of the form my-project. The suggested solution in #4467 wouldn't work for it anyway. I will also monkey patch the regex.
7. tseaver commented on Dec 6, 2017

   

   tseaver

   on Dec 6, 2017

   Contributor

   More actions

   The resource manager API docs say:

   The unique, user-assigned ID of the Project. It must be 6 to 30 lowercase letters, digits, or hyphens. It must start with a letter. Trailing hyphens are prohibited.
8. dhermes commented on Dec 6, 2017

   

   dhermes

   on Dec 6, 2017

   Contributor

   More actions

   @tseaver Nice find! (I assume you are implicitly saying "The current regex doesn't match that.")
9. chemelnucfin commented on Dec 6, 2017

   

   chemelnucfin

   on Dec 6, 2017 via email

   Contributor

   More actions

   Thanks! I'll fix it.

   …

   On Wed, Dec 6, 2017, 1:19 PM Danny Hermes ***@***.***> wrote: @tseaver <https://github.com/tseaver> Nice find! (I assume you are implicitly saying "The current regex doesn't match that.") — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4447 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADzDDMskMUejuLstrMblmlcEi_-pW9YRks5s9wTWgaJpZM4QqHga> .
10. tseaver commented on Dec 6, 2017

    

    tseaver

    on Dec 6, 2017

    Contributor

    More actions

    The current regex insists on three hyphen-separated tokens, the first two of which must be alpha-only, and the last of which must be numeric-only. A regex which fits the spec I quoted would be:

    _PROJECT_PATTERN = r'(?P<project>[a-z0-9-]{5,29}[a-z0-9])'
11. tseaver commented on Dec 6, 2017

    

    tseaver

    on Dec 6, 2017

    Contributor

    More actions

    FTR, pythex is a cool way to test / debug regexes.
12. chemelnucfin commented on Dec 13, 2017

    

    chemelnucfin

    on Dec 13, 2017

    Contributor

    More actions

    Closed via #4543
13. chemelnucfin

    closed this as completedon Dec 13, 2017
14. JustinBeckwith

    assigned

    chemelnucfin

    on Feb 1, 2021