google.cloud.error_reporting AttributeError: 'Client' object has no attribute '_project' #3233

Activity

1. DizzeePascall commented on Mar 29, 2017

   

   DizzeePascall

   on Mar 29, 2017

   Last edited by DizzeePascall

   ContributorAuthor

   More actions

   The problem seems to exist because PRs #3168 and #3159 have interefered with each other
2. dhermes commented on Mar 29, 2017

   

   dhermes

   on Mar 29, 2017

   Last edited by dhermes

   Contributor

   More actions

   @DizzeePascall We just pushed 0.23.2 to fix this issue. Can you try updating?

   Happy to re-open if this is still an issue for you.
3. dhermes

   closed this as completedon Mar 29, 2017
4. dhermes

   added

   api: clouderrorreportingIssues related to the Error Reporting API.Issues related to the Error Reporting API.

   on Mar 29, 2017
5. DizzeePascall commented on Mar 29, 2017

   

   DizzeePascall

   on Mar 29, 2017

   ContributorAuthor

   More actions

   @dhermes I'm running 0.23.2. As I mentioned, two PRs were filed to address a similar problem in 0.23.1, but ironically they've cancelled each other out. This shouldn't be closed yet
6. dhermes commented on Mar 29, 2017

   

   dhermes

   on Mar 29, 2017

   Last edited by dhermes

   Contributor

   More actions

   Thanks for the heads up. Can you post the snippet you used that failed so we can confirm as well? (You like linked to one PR and one issue, maybe you meant to link to two PRs?)
7. dhermes

   reopened this on Mar 29, 2017
8. DizzeePascall commented on Mar 29, 2017

   

   DizzeePascall

   on Mar 29, 2017

   ContributorAuthor

   More actions

   @dhermes Good point, I've updated my comment above
9. dhermes commented on Mar 29, 2017

   

   dhermes

   on Mar 29, 2017

   Contributor

   More actions

   Confirming the issue:

   $ git grep -n '\._project' -- error_reporting/
   error_reporting/google/cloud/error_reporting/_gax.py:44:    return _ErrorReportingGaxApi(gax_client, client._project)
   error_reporting/google/cloud/error_reporting/_gax.py:60:        self._project = project
   error_reporting/google/cloud/error_reporting/_gax.py:73:        project_name = self._gax_api.project_path(self._project)
   error_reporting/tests/unit/test__gax.py:55:        self.assertIs(report_error_client._project, client._project)
   error_reporting/tests/unit/test__gax.py:71:        self.assertEqual(gax_client_wrapper._project, self.PROJECT)
   $ # WHERE/WHEN
   $ git log -1 --pretty=%H
   e63ddc384e4a54a6a085595d779a399ed449c26c
   
10. asilversempirical commented on Mar 30, 2017

    

    asilversempirical

    on Mar 30, 2017

    More actions

    Any ETA on a fix for this? My team's error reporting is broken on this. Should we just temporarily pin to .23.0?
11. dhermes commented on Mar 30, 2017

    

    dhermes

    on Mar 30, 2017

    Contributor

    More actions

    @asilversempirical Hopefully 0.24.0 (not 0.23.2) will come out this afternoon via #3245
12. asilversempirical commented on Mar 30, 2017

    

    asilversempirical

    on Mar 30, 2017

    More actions

    Excellent, thank you for being on top of this :)
13. lukesneeringer commented on Mar 31, 2017

    

    lukesneeringer

    on Mar 31, 2017

    Contributor

    More actions

    We missed yesterday afternoon, but it is coming out this morning.
14. lukesneeringer commented on Apr 4, 2017

    

    lukesneeringer

    on Apr 4, 2017

    Contributor

    More actions

    This issue should be fixed in 0.24.0.
15. lukesneeringer

    closed this as completedon Apr 4, 2017
16. JustinBeckwith

    assigned

    dhermes

    on Feb 1, 2021