Repository navigation
Pycodestyle update causing our lint to fail. #2974
Description
From what I can tell, there are three new errors that pycodestyle is finding.
E306: expected 1 blank line before a nested definition, found 0
E123: closing bracket does not match indentation of opening bracket's line
E722: do not use bare except
See: #2973
Activity
dhermes commentedon Jan 30, 2017
E123seems legitdaspecster commentedon Jan 30, 2017
Yeah, I updated the PR to just fix the E123 errors.
dhermes commentedon Jan 30, 2017
I filed PyCQA/pycodestyle#621
dhermes commentedon Jan 31, 2017
They fixed it in
2.3.1dhermes commentedon Jan 31, 2017
@daspecster I should've been more specific, they fixed the
E306false positives. We still have theE722and maybe theE123issues to deal withdaspecster commentedon Jan 31, 2017
Yeah I saw, maybe closed this too soon, but the rest are resolved in #2973 either way. I have an update to remove the ignore for E306 then it should be good IMO.