Repository navigation
The value of more_results from storage.Connection.run_query should not be thrown away. #280
Description
I'm currently writing a regression test that checks for more items after a fetch with a limit set and this boolean would determine if the next fetch (at the final cursor) contains all the remaining results.
As a side note, the Node regression needlessly re-queries with a cursor which (should) point to the end of the kind.
/cc @silvolu
Activity
Adding support for queries in regression test.
Adding support for queries in regression test.
silvolu commentedon Oct 22, 2014
@dhermes the reason for that is described in this issue (basically it doesn't really work as you'd expect).
Adding support for queries in regression test.
Adding support for queries in regression test.
dhermes commentedon Oct 23, 2014
@silvolu Are you saying that googleapis/google-cloud-node#5 says that
more_resultsis not a value that can be consistently trusted? Only @rakyll's issue description mentions the value ofmore_results.UPDATE: FWIW I tested this on #281 and
more_resultswas always equal to2, irrespective of the query, which is the enum value ofMORE_RESULTS_AFTER_LIMIT.silvolu commentedon Oct 23, 2014
The backend keeps returning MORE_RESULTS_AFTER_LIMIT even when there are none.
dhermes commentedon Oct 23, 2014
Cool. I'd like to add this to the code as a comment and a reference to this issue. SG?
silvolu commentedon Oct 23, 2014
SGTM
34 remaining items
chore(deps): update actions/download-artifact action to v3 (#280)
chore(deps): Fix possible dependency conflict with `google-api-core` …
fix: limit data transferred as part of list_documents as we don't req…
chore(deps): update dependency pytest to v6.2.4 (#280)
chore(deps): update dependency pytest to v6.2.4 (#280)
fix: Finish implementation of UserProperty. (#301)
chore(deps): update dependency pytest to v6.2.4 (#280)
chore(deps): update dependency pytest to v6.2.4 (#280)
Make classifiers in setup.py an array. (#280)
chore(main): release 1.7.1 (#280)
chore: release 2.1.0 (#280)
chore(deps): update dependency pyjwt to v2.6.0 (#280)
chore: skip reporting coverage for namespace package, update secrets …
fix: allow multiple/custom index pages to be used (#280)
chore(main): release 1.7.1 (#280)