Vision raises TypeError: b'...' is not JSON serializable on Python 3

Simple reproducible case:

import io
import os

from google.cloud import vision

vision_client = vision.Client()

file_name = os.path.join(
    os.path.dirname(__file__),
    'resources/wakeupcat.jpg')

with io.open(file_name, 'rb') as image_file:
    image = vision_client.image(
        content=image_file.read())

labels = image.detect_labels()

print('Labels:')
for label in labels:
    print(label.description)

works fine on Python 2, fails on Python 3.

Stack trace:

Traceback (most recent call last):
  File "quickstart.py", line 51, in <module>
    run_quickstart()
  File "quickstart.py", line 38, in run_quickstart
    image = vision_client.image(
  File "/Users/jonwayne/.pyenv/versions/3.4.3/lib/python3.4/site-packages/google/cloud/vision/image.py", line 139, in detect_labels
    return self._detect_annotation(feature)
  File "/Users/jonwayne/.pyenv/versions/3.4.3/lib/python3.4/site-packages/google/cloud/vision/image.py", line 105, in _detect_annotation
    result = self.client.annotate(self, [feature])
  File "/Users/jonwayne/.pyenv/versions/3.4.3/lib/python3.4/site-packages/google/cloud/vision/client.py", line 106, in annotate
    data=data)
  File "/Users/jonwayne/.pyenv/versions/3.4.3/lib/python3.4/site-packages/google/cloud/connection.py", line 341, in api_request
    data = json.dumps(data)
  File "/Users/jonwayne/.pyenv/versions/3.4.3/lib/python3.4/json/__init__.py", line 230, in dumps
    return _default_encoder.encode(obj)
  File "/Users/jonwayne/.pyenv/versions/3.4.3/lib/python3.4/json/encoder.py", line 192, in encode
    chunks = self.iterencode(o, _one_shot=True)
  File "/Users/jonwayne/.pyenv/versions/3.4.3/lib/python3.4/json/encoder.py", line 250, in iterencode
    return _iterencode(o, 0)
  File "/Users/jonwayne/.pyenv/versions/3.4.3/lib/python3.4/json/encoder.py", line 173, in default
    raise TypeError(repr(o) + " is not JSON serializable")

Same issue fixed by #2520?

Seems like it, vision probably just needs a similar patch.

@daspecster

Oh my blindness!

@daspecster Do the system tests for vision not cover this?

Zoinks! That bytes. I will get on this right now.

That bytes

heheh.

@dhermes

@dhermes Also, sadly there are no system tests for this.
I made an issue to add system tests though.

#2526

Ah. That is no good. We should not have pushed to PyPI without system tests. Live and learn.

@dhermes

Agreed. I don't think we even brought it up anywhere.

@dhermes I don't think I have access to the system test project(precise-truck?) to add things like images and audio to run the tests on.

@daspecster

@daspecster Get them working locally first and then we can cross that bridge?

Ok, will do.

Properly encode image content. Fixes googleapis#2525.

@jonparrott

@jonparrott just merged the fix for this. Let me know if you run into any more issues! Thanks!

@jonparrott

Thanks, will await the next release before I can test it.

On Wed, Oct 12, 2016, 7:45 AM Thomas Schultz notifications@github.com
wrote:

@jonparrott https://github.com/jonparrott just merged the fix for this.
Let me know if you run into any more issues! Thanks!

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#2525 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUc3RxuTcsGvHx7vFGrIQwKll2AjcVks5qzPFygaJpZM4KUGtJ
.

@jonparrott

I'm waiting for the fix for this issue to be released. @jonparrott Do you know when the next release will be?

It's been released, @meta221

Properly encode image content. Fixes googleapis#2525.

Properly encode image content. Fixes #2525.

build(deps): bump pyasn1 from 0.6.1 to 0.6.2 (#2525)

refactor: Improve cache encapsulation (#2525)

Navigation Menu

Repository navigation

Vision raises TypeError: b'...' is not JSON serializable on Python 3 #2525

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Vision raises TypeError: b'...' is not JSON serializable on Python 3 #2525

Description

Activity

theacodes commented on Oct 11, 2016

dhermes commented on Oct 11, 2016

theacodes commented on Oct 11, 2016

dhermes commented on Oct 11, 2016

daspecster commented on Oct 11, 2016

theacodes commented on Oct 11, 2016

daspecster commented on Oct 11, 2016

dhermes commented on Oct 11, 2016

daspecster commented on Oct 11, 2016

dhermes commented on Oct 11, 2016

daspecster commented on Oct 11, 2016

daspecster commented on Oct 12, 2016

theacodes commented on Oct 12, 2016

talzion12 commented on Nov 9, 2016

theacodes commented on Nov 15, 2016

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions