Repository navigation
Should language document_from_text() etc. be a reference to the Document class #2183
Description
The question is whether we should have Client.document_from_foo methods or just have Client.document be a reference to the class Document and then use Client.document.from_foo.
This amounts to swapping _ for . (i.e. no less typing) and makes a "proper noun" like Document be referenced as an "improper noun" as a property, which is not a win IMO
Reacted by Tres Seaver
Activity
[-]Should language document_from_text() etc. by a reference to the Document class[/-][+]Should language document_from_text() etc. be a reference to the Document class[/+]lukesneeringer commentedon Aug 8, 2017
Hello!
We have done a less-than-great job of dealing with issues in this repository. Sorry about that. :-(
In this case, we have released an entirely different version of
google-cloud-language, which is very likely to have solved this issue, so I am going and closing language-related issues en masse to try and regain sanity and ability to tackle things.Please upgrade to the newest version of
google-cloud-languageand useLanguageServiceClient. Note that this will require a code change. If your issue persists, feel free to reopen. :-)fix python2 print unicode issue [(#2183)](GoogleCloudPlatform/python-…
chore: Fix two types of warnings in unit tests (#2183)
feat: Support len() on Groupby objects (#2183)