You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Make sure all snippets are in snippets files #2154
Hello,
One of the challenges of maintaining a large open source project is that sometimes, you can bite off more than you can chew. As the lead maintainer of google-cloud-python, I can definitely say that I have let the issues here pile up.
As part of trying to get things under control (as well as to empower us to provide better customer service in the future), I am declaring a "bankruptcy" of sorts on many of the old issues, especially those likely to have been addressed or made obsolete by more recent updates.
My goal is to close stale issues whose relevance or solution is no longer immediately evident, and which appear to be of lower importance. I believe in good faith that this is one of those issues, but I am scanning quickly and may occasionally be wrong. If this is an issue of high importance, please comment here and we will reconsider. If this is an issue whose solution is trivial, please consider providing a pull request.
We could certainly add support for exercising the snippets just as easily as adding doctest support. Note that the doctests are currently used only in datastore, and only in docstrings (there are no narrative docs at all for datastore), so the use-cases may be different.
Activity
dhermes commentedon Apr 19, 2017
@lukesneeringer This never got done and we currently have stale snippets in
docs/*_snippets.py.lukesneeringer commentedon Apr 19, 2017
Sold. Reopening.
lukesneeringer commentedon Aug 11, 2017
Hello,
One of the challenges of maintaining a large open source project is that sometimes, you can bite off more than you can chew. As the lead maintainer of
google-cloud-python, I can definitely say that I have let the issues here pile up.As part of trying to get things under control (as well as to empower us to provide better customer service in the future), I am declaring a "bankruptcy" of sorts on many of the old issues, especially those likely to have been addressed or made obsolete by more recent updates.
My goal is to close stale issues whose relevance or solution is no longer immediately evident, and which appear to be of lower importance. I believe in good faith that this is one of those issues, but I am scanning quickly and may occasionally be wrong. If this is an issue of high importance, please comment here and we will reconsider. If this is an issue whose solution is trivial, please consider providing a pull request.
Thank you!
dhermes commentedon Aug 11, 2017
@lukesneeringer You were sold once upon a time on this.
FWIW I'd prefer we use
doctestover snippets files.tseaver commentedon Aug 12, 2017
We could certainly add support for exercising the snippets just as easily as adding doctest support. Note that the doctests are currently used only in
datastore, and only in docstrings (there are no narrative docs at all for datastore), so the use-cases may be different.lukesneeringer commentedon Aug 12, 2017
And in four months, none of us touched it. I am skeptical that another four months would change this.
In the Node.js reorganization, we are handling some conversion of tests; I could see the Python equivalent as a good venue for that.
fix: table iterator should not use bqstorage when page_size is not No…
Revert "fix: table iterator should not use bqstorage when page_size i…
feat: make `all` and `any` compatible with integer columns on Polars …