Repository navigation
'gax-google-pubsub-v1' and 'gax-google-logging-v2' wreck the 'google.protobuf' namespace #1972
Description
/cc @bjwatson, @tbetbetbe, @rok987
The failure only shows up when things are installed via easy_install (vs. pip). The two packages each include and empty google/protobuf/__init__.py, without any namespace package declaration for it (or any purpose). When installed in a particular order via easy_install / setup.py develop, the bogus google.protobuf package ends up higher on sys.path than the real google.protobuf, and mayhem ensues.
The fix would be to just drop them from the sdists altogether.
Activity
bjwatson commentedon Jul 15, 2016
@geigerj What do you think? This seems easy to do as part of rolling new releases of these libraries for #1979.
geigerj commentedon Jul 15, 2016
Yes, I will do this when I release the new libraries. I will also fix googleapis/gapic-generator#239 next, which will stop us from generating these bogus packages.
tseaver commentedon Jul 16, 2016
@geigerj that would be great, thanks!
geigerj commentedon Jul 18, 2016
I've put up new versions of those packages without the
google.protobufpackage.tseaver commentedon Jul 18, 2016
@geigerj Thank you! I just verified that
bin/easy_install gcloud-pythonin a fresh virtualenv pulls ingax-google-pubsub-v10.17.12 andgax-google-logging-v20.17.12, and that they do not break imports fromgoogle.protobuf.*.feat: add support for checking uuid4 fields (#1972)
deps: bump min version of google-api-core and google-cloud-core to 2.x (
perf: remove an unnecessary extra `dry_run` query from `read_gbq_tabl…