Skip to content

In storage.Key.set_contents_from_file, check response code on write and backoff exponentially on failure #149

Closed
Closed
In storage.Key.set_contents_from_file, check response code on write and backoff exponentially on failure#149
Assignees
silvolu
Labels
🚨This issue needs some love.api: storageIssues related to the Cloud Storage API.triage meI really want to be triaged.
Milestone
Storage Stable

Description

@dhermes
dhermes
opened on Sep 22, 2014

From TODO:

      # TODO: Error checking for response code.
      # TODO: Exponential backoff when errors come through.

See gcloud.storage.Key.set_contents_from_file for relevant code and #146 for some context.

Activity

  1. dhermes commented on Sep 22, 2014

    @dhermes
    dhermes
    on Sep 22, 2014
    ContributorAuthor

    git blame output

    b7f1b774 (JJ Geewax   2014-01-29 18:02:29 -0500 242)       # TODO: Error checking for response code.
b7f1b774 (JJ Geewax   2014-01-29 18:02:29 -0500 243)       # TODO: Exponential backoff when errors come through.
``
  2. tseaver
    added
    api: storageIssues related to the Cloud Storage API.
    on Sep 22, 2014
  3. silvolu
    added this to the milestone on Sep 24, 2014

  4. tseaver commented on Oct 28, 2014

    @tseaver
    tseaver
    on Oct 28, 2014
    Contributor

    Should rely on the fact that the underlying Connection.make_request will raise error (via httplib2) and not try to re-wrap it. Or should we consider this moot in light of the choice to replace the guts of the upload stuff with apitools?

  5. dhermes commented on Oct 28, 2014

    @dhermes
    dhermes
    on Oct 28, 2014
    ContributorAuthor

    Declaring it moot seems the happiest future.

  6. silvolu commented on Oct 29, 2014

    @silvolu
    silvolu
    on Oct 29, 2014
    Contributor

    Declaring moot. We'll get this for free from apitools.

  7. silvolu
    closed this as completedon Oct 29, 2014
  8. jgeewax
    modified the milestones: , Storage Stable on Jan 30, 2015
  9. urshala
    added a commit that references this issue on Jan 17, 2020

    Fixed googleapis#149

    dc66d42
  10. yoshi-automation
    added
    triage meI really want to be triaged.
    🚨This issue needs some love.
    on Apr 7, 2020
  11. JustinBeckwith
    assigned
    silvolu
    on Feb 1, 2021

  12. 88 remaining items

  13. parthea
    added a commit that references this issue on Sep 16, 2025

    chore: exclude tarball from code generation (#149)

    9c9a89f
  14. parthea
    added 12 commits that reference this issue on Nov 22, 2025

    chore(deps): update dependency google-cloud-core to v1.4.2 (#149)

    a12ceff

    chore: test minimum dependencies in python 3.7 (#149)

    f2b0d5f

    chore: [autoapprove] Update `black` and `isort` to latest versions (#149

    71f302c

    Bump the version number to 11 (#149)

    5485cc5

    chore: release 1.10.2 (#149)

    b4247ac

    chore(librarian): update image sha and clean up unused files (#149)

    2e94122

    fix: add mypy checking + 'py.typed' files (#149)

    d7d568e

    build: migrate to flakybot (#149)

    70196a5

    chore: update dependency protobuf >= 3.20.2 (#149)

    b6568d7

    chore(python): refactor unit / system test dependency install (#149)

    c00dda5

    chore(deps): update dependency google-cloud-documentai to v2.18.0 (#149)

    f6bd33f

    build(python): remove python 3.7 from kokoro Dockerfile (#149)

    403dc6c
  15. parthea
    added 2 commits that reference this issue on Mar 2, 2026

    docs: use googleapis.dev docs link (#149)

    09efa8c

    django: fix ORDER BY NULLS FIRST / LAST

    dfaacc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.api: storageIssues related to the Cloud Storage API.triage meI really want to be triaged.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions