You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Oh, I did not realize this. We certainly can. Both Jacob and @aozarov thought that this was a good idea, and I kind of agree. I am restoring the comment in the doc and pausing here.
Errr - really? I don't love this... can we debate a bit more first.... ?
The issue is that what we call DnsRecord does not actually represent one DNS record but rather a set of records (and therefore is called in the underlying service API ResourceRecordSet).
BTW, it looks like this long name was adopted by gcloud-python though node choose Record (which I personally think is wrong).
I think the main point is to indicate that it is a set rather than an individual item and therefore my ordered preference would be: RecordSet, DnsRecordSet, ResourceRecordSet.
With a much stronger preference to the first.
Activity
jgeewax commentedon Mar 23, 2016
Errr - really? I don't love this... can we debate a bit more first.... ?
mderka commentedon Mar 23, 2016
Oh, I did not realize this. We certainly can. Both Jacob and @aozarov thought that this was a good idea, and I kind of agree. I am restoring the comment in the doc and pausing here.
[-]Rename class DnsRecord to ResourceRecordSet[/-][+]Rename class DnsRecord[/+]mderka commentedon Mar 23, 2016
I renamed the issue. The final name is to be decided after some discussion. The suggestions are DnsRecordSet and ResourceRecordSet.
ajkannan commentedon Mar 23, 2016
I slightly prefer DnsRecordSet over ResourceRecordSet, but I'm fine with either. RecordSet would be shorter; do you think it's a clear enough name?
aozarov commentedon Mar 23, 2016
The issue is that what we call
DnsRecorddoes not actually represent one DNS record but rather a set of records (and therefore is called in the underlying service APIResourceRecordSet).BTW, it looks like this long name was adopted by gcloud-python though node choose Record (which I personally think is wrong).
I think the main point is to indicate that it is a set rather than an individual item and therefore my ordered preference would be:
RecordSet,DnsRecordSet,ResourceRecordSet.With a much stronger preference to the first.
mderka commentedon Mar 23, 2016
After some discussion both here and internally, including the input from the DNS team, we will rename to
RecordSet.Renamed DnsRecord to RecordSet. Fixes googleapis#779.
Renamed DnsRecord to RecordSet. Fixes googleapis#779.
Renamed DnsRecord to RecordSet. Fixes googleapis#779.
Merge pull request #784 from mderka/rename-dns-record
14 remaining items
chore(main): release 2.5.12-SNAPSHOT (#779)
ci: run downstream native image tests (#779)
chore: release 3.5.2 (#779)
build(deps): update dependency com.google.cloud:google-cloud-shared-c…
fix(java): java 17 dependency arguments (#1266) (#779)
chore: release 1.3.0 (#777)
chore: release 3.5.2 (googleapis#779)
fix(java): java 17 dependency arguments (#1266) (#779)
chore: release 1.3.0 (#777)
test(deps): update dependency org.mockito:mockito-core to v4.4.0 (goo…
chore: add enumeration type of library (#779)
chore: add enumeration type of library (#779)
chore(deps): update dependency com.google.cloud:google-cloud-pubsub t…
chore(deps): update dependency com.google.cloud:google-cloud-pubsub t…
build(deps): update dependency com.google.cloud:google-cloud-shared-c…