Skip to content

google-cloud-logging LogEntry is missing a "spanId" field. #3325

Closed

Description

@sebright2

I'm writing a LoggingEnhancer for OpenCensus (census-instrumentation/opencensus-java#1212). I noticed that the Stackdriver LogEntry has a "spanId" field in https://cloud.google.com/logging/docs/reference/v2/rest/v2/LogEntry, but the google-cloud-logging LogEntry class does not (LogEntry.java). Should both LogEntry data structures have a "spanId"? If so, I can make a pull request to add the field.

/cc @g-easy

Activity

  1. added
    api: loggingIssues related to the Cloud Logging API.
    priority: p2Moderately-important priority. Fix may not be included in next release.
    type: questionRequest for information or clarification. Not an issue.
    on May 31, 2018
  2. yihanzhen commented on May 31, 2018

    @yihanzhen
    Contributor

    That sounds quite reasonable to me. Please feel free to send over pull requests.
    (I don't know a lot about logging so @garrettjonesgoogle @pongad please share your inputs if you see a problem here)

  3. added a commit that references this issue on Jun 1, 2018
    c0d9f06
  4. sebright2 commented on Jun 1, 2018

    @sebright2
    Author

    Thanks! I made a PR: #3332

  5. added a commit that references this issue on Jun 4, 2018
    db2da59
  6. added a commit that references this issue on Sep 18, 2018
    d9d7adc
  7. added a commit that references this issue on Dec 22, 2025
    aaf9ee2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: loggingIssues related to the Cloud Logging API.priority: p2Moderately-important priority. Fix may not be included in next release.type: questionRequest for information or clarification. Not an issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions