Skip to content

Create new efficient batching implementation for Pub/Sub and Logging #3003

Closed

Description

@garrettjonesgoogle

Try to support BigTable too.

  • Bigtable
  • Pub/Sub
  • Logging

Activity

  1. added
    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
    api: pubsubIssues related to the Pub/Sub API.
    api: loggingIssues related to the Cloud Logging API.
    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.
    on Mar 6, 2018
  2. added
    priority: p2Moderately-important priority. Fix may not be included in next release.
    and removed
    🚨 criticalP0 critical issue. Requires immediate fix
    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.
    on Jun 26, 2018
  3. added
    api: bigtableIssues related to the Bigtable API.
    and removed
    🚨 criticalP0 critical issue. Requires immediate fix
    priority: p2Moderately-important priority. Fix may not be included in next release.
    on Oct 9, 2018
  4. sduskis commented on Jun 12, 2019

    @sduskis
    Contributor

    This is in progress for Cloud Bigtable: https://github.com/googleapis/gax-java/pulls?utf8=%E2%9C%93&q=is%3Apr+batcher

    This will land eventually.

  5. removed their assignment
    on Jun 12, 2019
  6. IRus commented on Sep 13, 2019

    @IRus

    Does this new API will include ability to publish list of messages? Like fun publish(messages: List<PubsubMessage>): ApiFuture<List<String>>

  7. rahulKQL commented on Sep 20, 2019

    @rahulKQL
    Contributor

    @IRus Sorry for the late response. As of now, we have yet to implement this feature on google-cloud-pubsub.

    The surface for that is not yet finalized but it would support something similar to Batcher<PubsubMessage, String>, then one can perform batching with this batcher.

  8. jmouvill commented on Oct 11, 2019

    @jmouvill

    What would be the difference with the current BatchSettings available on the Publisher's builder ?
    i.e:

    Publisher
          .newBuilder(topic)
          .setBatchingSettings(
            BatchingSettings.newBuilder.
              setFlowControlSettings(...)
              .setElementCountThreshold(...)
              .setRequestByteThreshold(...)
              .setDelayThreshold(...)
              .build
        )
    

    where you can specify an elementCountThreshold, requestByteThreshold etc ?

  9. rahulKQL commented on Oct 11, 2019

    @rahulKQL
    Contributor

    @jmouvill This feature has been little delayed for Pubsub, but I would say BatchingSettings configurations would be similarly respected in new batching impl. We are planning to use the same BatchingSettings to set thresholds for Batcherinstance.

  10. chingor13 commented on Jan 7, 2020

    @chingor13
    Contributor

    This issue has been split into the 2 linked tracking issues to implement in the logging and pubsub clients respectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: bigtableIssues related to the Bigtable API.api: loggingIssues related to the Cloud Logging API.api: pubsubIssues related to the Pub/Sub API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions