Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

batching: set default settings to no-batching - #397

Merged
pongad merged 1 commit into
googleapis:masterfrom
pongad:batch-default
Oct 31, 2017
Merged

pongad merged 1 commit into
googleapis:masterfrom
pongad:batch-default

Conversation

@pongad

@pongad pongad commented Oct 30, 2017

Copy link
Copy Markdown
Contributor

@pongad

pongad commented Oct 30, 2017

Copy link
Copy Markdown
Contributor Author

@garrettjonesgoogle This is technically a breaking change (see the changed test for example). Are we OK with this?

@codecov-io

codecov-io commented Oct 30, 2017 •

Copy link
Copy Markdown

Codecov Report

Merging #397 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #397      +/-   ##
===========================================
- Coverage     74.11%   74.1%   -0.01%     
  Complexity      522     522              
===========================================
  Files           135     135              
  Lines          2712    2715       +3     
  Branches        194     194              
===========================================
+ Hits           2010    2012       +2     
  Misses          624     624              
- Partials         78      79       +1
Impacted Files Coverage Δ Complexity Δ
.../com/google/api/gax/batching/BatchingSettings.java 77.27% <100%> (-1.68%) 2 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4f2225...ca1e3b9. Read the comment docs.

@garrettjonesgoogle garrettjonesgoogle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pongad
pongad merged commit b6da833 into googleapis:master Oct 31, 2017
@pongad
pongad deleted the batch-default branch October 31, 2017 03:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants