Repository navigation
fix(stages-aw): coalesce assured_workloads.folder in Stage 2/3 parent fallbacks - #426
Open
johnlakeee wants to merge 1 commit into
Open
johnlakeee wants to merge 1 commit into
johnlakeee wants to merge 1 commit into
Conversation
8 tasks done
aghassemlouei
requested changes
Nov 17, 2026
aghassemlouei
left a comment
Member
There was a problem hiding this comment.
Thanks for aligning the Stage 2b and Stage 3 folder parent fallback order with Stage 2a. Inspecting the variable definitions across the three stages surfaced one null-safety mismatch in fast/stages-aw/2-networking-b-il5-ngfw along with a pull request template gap:
- Unlike
fast/stages-aw/2-networking-a-fedramp/variables.tfandfast/stages-aw/3-security/variables.tf, which declarevariable "assured_workloads"withtype = object({ regime = optional(string), location = optional(string), folder = optional(string) }),nullable = false, anddefault = {},fast/stages-aw/2-networking-b-il5-ngfw/variables.tflines 22 to 26 declaretype = anyanddefault = null. Whenvar.assured_workloadsis left at its defaultnullor set to{}without afolderkey, evaluatingvar.assured_workloads.folderinfast/stages-aw/2-networking-b-il5-ngfw/main.tfline 32 failsterraform planwithAttempt to get attribute from null valueorUnsupported attribute. - Please update
variable "assured_workloads"infast/stages-aw/2-networking-b-il5-ngfw/variables.tfto match the typed object schema in2-networking-a-fedramp/variables.tfand3-security/variables.tfand regeneratefast/stages-aw/2-networking-b-il5-ngfw/README.mdwithtools/tfdoc.py. - Please also include the
## Deployment & Compliance Impactand## Checklistsections from.github/pull_request_template.mdin the pull request description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Align
fast/stages-aw/2-networking-b-il5-ngfw/main.tfandfast/stages-aw/3-security/main.tfwith2-networking-a-fedramp/main.tfby coalescingvar.common_services_folderandvar.assured_workloads.folderbefore falling back toorganizations/${var.organization.id}.module "folder".parentin2-networking-b-il5-ngfw/main.tfand3-security/main.tftests/test_stage_folder_fallbacks.pyPart of #388 (Milestone 1 — Group A, PR 5 of 6).
Type of Change
Testing Performed
terraform fmt -check -recursive,terraform validate,tflint(155 directories, 0 failed)ruff check&ruff format --checkpytest: 132 passedtests/test_*.shshell suites passed