Skip to content

fix(1-resman): resolve per-tenant KMS location from tenant_info - #423

Open
johnlakeee wants to merge 1 commit into
mainfrom
fix/1-resman-tenant-kms-location
Open

johnlakeee wants to merge 1 commit into
mainfrom
fix/1-resman-tenant-kms-location

Conversation

@johnlakeee

Copy link
Copy Markdown
Collaborator

Description

In fast/stages-aw/1-resman/kms.tf, local.tenant_envs wraps tenant variables under tenant_info, so each.value.locations.kms always failed try(..., false) and fell back to var.regions.primary.

  • Update keyring and KMS key locations to read each.value.tenant_info.locations.kms
  • Add unit test tests/test_resman_kms.py

Part of #388 (Milestone 1 — Group A, PR 2 of 6).

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Testing Performed

  • terraform fmt -check -recursive, terraform validate, tflint (155 directories, 0 failed)
  • ruff check & ruff format --check
  • pytest: 133 passed
  • All tests/test_*.sh shell suites passed

@github-actions github-actions Bot added Scope - Fast Related to Fabric FAST deployment stages in the fast directory Bug Something isn't working Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete Priority - Medium Standard features and non-blocking bugs; important for the current milestone but not urgent labels Nov 16, 2026

@aghassemlouei aghassemlouei left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the per-tenant KMS location lookup in fast/stages-aw/1-resman/kms.tf. The each.value.tenant_info.locations.kms resolution across all three references matches local.tenant_envs in fast/stages-aw/1-resman/branch-tenants.tf.

  • Please rebase the branch onto main now that #419 has merged updates to fast/stages-aw/1-resman/kms.tf.
  • Please add the ## Deployment & Compliance Impact and ## Checklist sections from .github/pull_request_template.md to the pull request description before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete Priority - Medium Standard features and non-blocking bugs; important for the current milestone but not urgent Scope - Fast Related to Fabric FAST deployment stages in the fast directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants