Skip to content

fix(networking): remove unsupported route_tags on cross-spoke SWP egress routes - #412

Merged
Calvin-Cheng1 merged 2 commits into
mainfrom
fix/networking-swp-ncc-untagged-routes
Nov 10, 2026
Merged

Calvin-Cheng1 merged 2 commits into
mainfrom
fix/networking-swp-ncc-untagged-routes

Conversation

@aghassemlouei

Copy link
Copy Markdown
Member

Description

Follows up on the #404 review comment with @Calvin-Cheng1 to remove centralized_egress.route_tags and its tags bindings on google_compute_route.hub_swp_egress and google_compute_route.spoke_swp_egress in fast/stages-aw/2-networking-a-fedramp.

Both hub-0 and each <env>-spoke-0 VPC live in separate VPC spokes from egress-0, which hosts the centralized Secure Web Proxy internal passthrough Network Load Balancer. Per the Network Connectivity Center static routes requirements, cross-spoke static routes targeting an internal passthrough Network Load Balancer in another VPC spoke cannot carry network tags, so setting a non-empty route_tags list causes route validation and forwarding issues across Network Connectivity Center. Keeping both 0.0.0.0/0 next_hop_ilb routes untagged preserves valid cross-spoke centralized egress routing.

Fixes # N/A

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Deployment & Compliance Impact

  • Applicable Regimes:
    • US Region Restricted (e.g., Access Policy constraint)
    • FedRAMP Moderate
    • FedRAMP High
    • DoD IL4
    • DoD IL5
    • General / All
  • NIST 800-53r5 Controls: SC-7 (Boundary Protection) and AC-4 (Information Flow Enforcement) for centralized Secure Web Proxy internet egress across Network Connectivity Center VPC spokes.

Checklist

Code Quality & Reusability

  • My code adheres to the Maximize Reusability principle. I have not redefined common elements and have reused existing base configurations and modules where possible.
  • I have checked that no existing module or configuration in modules/ or fast/stages-aw/ can be leveraged for this change.
  • My code follows the established naming conventions outlined in docs/naming-convention.md.

Documentation

  • I have updated the README.md of the modified module or blueprint.
  • I have added/updated documentation for inputs (variables) and outputs.

Security

  • My change adheres to GCP security best practices and the principle of least privilege.
  • I have ensured compliance with the targeted regime (FedRAMP Moderate, FedRAMP High, IL4, IL5, etc.).

Testing

  • I have tested my changes locally.
  • I have included details of my testing in this PR.

Testing Performed

  • Verified python3 -m unittest discover -s tests -p '*stage2*' -v passes all 8 Stage 2 networking unit tests, including regression assertions confirming route_tags and route tags are absent from fast/stages-aw/2-networking-a-fedramp/{variables.tf,egress.tf}.
  • Regenerated and verified fast/stages-aw/2-networking-a-fedramp/README.md variable anchors with tools/tfdoc.py.

@github-actions github-actions Bot added Scope - Fast Related to Fabric FAST deployment stages in the fast directory Bug Something isn't working Documentation Improvements or additions to documentation Framework - FedRAMP Moderate FedRAMP Moderate compliance regime and controls Framework - FedRAMP High FedRAMP High compliance regime and controls Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete Priority - High Critical issues blocking development or users; urgent bugs or core features for release Security Something is insecure or can be secured labels Nov 10, 2026
@aghassemlouei
aghassemlouei marked this pull request as ready for review November 10, 2026 18:08
@Calvin-Cheng1
Calvin-Cheng1 merged commit 6b51712 into main Nov 10, 2026
22 checks passed
@Calvin-Cheng1
Calvin-Cheng1 deleted the fix/networking-swp-ncc-untagged-routes branch November 10, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Documentation Improvements or additions to documentation Framework - FedRAMP High FedRAMP High compliance regime and controls Framework - FedRAMP Moderate FedRAMP Moderate compliance regime and controls Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete Priority - High Critical issues blocking development or users; urgent bugs or core features for release Scope - Fast Related to Fabric FAST deployment stages in the fast directory Security Something is insecure or can be secured

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants