Skip to content

ci(release): use single-dash Release Please branch names - #410

Merged
aghassemlouei merged 1 commit into
mainfrom
ci/release-please-branch-name
Nov 10, 2026
Merged

aghassemlouei merged 1 commit into
mainfrom
ci/release-please-branch-name

Conversation

@aghassemlouei

Copy link
Copy Markdown
Member

Description

Replaces the double-dash release-please--branches--main naming convention with release-please-branches-main for future Release Please pull requests while keeping in-flight v6.0.0 release pull request #394 on its existing release-please--branches--main branch until v6.0.0 merges:

  • Patches BranchName.ofTargetBranch, DefaultBranchName, and AutoreleaseBranchName.matches inside .github/workflows/release.yml to emit release-please-branches-<target> while still parsing legacy release-please--branches--<target> branch names when cutting Git tags and GitHub Releases on merge.
  • Extends Manifest.createOrUpdatePullRequest and the changelog sub-bullet pre-step in .github/workflows/release.yml to update any open release-please--branches--main pull request in place and read curated * ... sub-bullets from both legacy and single-dash release branches, switching to release-please-branches-main once #394 merges.
  • Updates section 6 of GEMINI.md and expands tests/test_label_taxonomy.py to cover single-dash branch generation, legacy branch parsing, AutoreleaseBranchName prefix exclusion, and in-place updates for open legacy release pull requests.

No GitHub issue exists for this change.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Deployment & Compliance Impact

  • Applicable Regimes:
    • US Region Restricted (e.g., Access Policy constraint)
    • FedRAMP Moderate
    • FedRAMP High
    • DoD IL4
    • DoD IL5
    • General / All
  • NIST 800-53r5 Controls: Not applicable for repository release workflow automation.

Checklist

Code Quality & Reusability

  • My code adheres to the Maximize Reusability principle. I have not redefined common elements and have reused existing base configurations and modules where possible.
  • I have checked that no existing module or configuration in modules/ or fast/stages-aw/ can be leveraged for this change.
  • My code follows the established naming conventions outlined in docs/naming-convention.md.

Documentation

  • I have updated the README.md of the modified module or blueprint.
  • I have added/updated documentation for inputs (variables) and outputs.

Security

  • My change adheres to GCP security best practices and the principle of least privilege.
  • I have ensured compliance with the targeted regime (FedRAMP Moderate, FedRAMP High, IL4, IL5, etc.).

Testing

  • I have tested my changes locally.
  • I have included details of my testing in this PR.

Testing Performed

  • Validated the .github/workflows/release.yml runtime sed and Node.js patch directly against the bundled googleapis/release-please-action v5.0.0 dist/index.js (node --check plus runtime verification of BranchName.ofTargetBranch('main'), BranchName.parse across single-dash and legacy double-dash branches, and AutoreleaseBranchName.matches on release-please-branches-v6.0).
  • Executed bash tools/run_tests.sh (122 Python unit tests including expanded test_release_workflow_normalizes_issue_and_pr_links_to_numbers coverage, 32 shell syntax checks, test_common_functions.sh, test_sync_from_cff.sh, test_tflint.sh, boilerplate header verification, and AST unused-variable checks).
  • Executed bash tools/lint.sh (all 10 repository lint gates passed, including ruff format --check and ruff check across 383 Python files).

@aghassemlouei aghassemlouei added Documentation Improvements or additions to documentation Enhancement New feature or request Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete Priority - Low Minor polish, typo fixes, or technical debt; nice to have; pick up when time permits labels Nov 10, 2026
@aghassemlouei aghassemlouei self-assigned this Nov 10, 2026
@aghassemlouei
aghassemlouei marked this pull request as ready for review November 10, 2026 03:12
@aghassemlouei
aghassemlouei merged commit 3d7d813 into main Nov 10, 2026
23 checks passed
@aghassemlouei
aghassemlouei deleted the ci/release-please-branch-name branch November 10, 2026 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation Enhancement New feature or request Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete Priority - Low Minor polish, typo fixes, or technical debt; nice to have; pick up when time permits

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant