Repository navigation
fix(0-bootstrap): let the Stage 0 folders inherit the logging settings - #361
Merged
aghassemlouei merged 1 commit intoOct 26, 2026
Merged
Conversation
Under Assured Workloads regimes that enforce CMEK for Logging through constraints/gcp.restrictNonCmekServices, such as IL5, the API rejects folder logging settings without a KMS key, and the folder module has no CMEK input. The common services folder therefore failed the first Stage 0 apply. The folders gain nothing from their own settings, because Stage 0 already applies the same storage location on the organization and folders inherit it. - Remove logging_settings from the common services and no-compliance folders. - Explain the inheritance next to the organization settings. - Add a test that only the organization sets the logging settings.
11 of 19 tasks
aghassemlouei
enabled auto-merge (squash)
October 26, 2026 18:28
Contributor
Author
|
Fixing the issue found by CI/CD. edit: it is in gem4gov CLI testing... |
9 of 19 tasks
aghassemlouei
left a comment
Member
There was a problem hiding this comment.
Verified fast/stages-aw/0-bootstrap across both IL5 and COMPLIANCE_REGIME_UNSPECIFIED configurations alongside bash tools/run_tests.sh and bash tools/lint.sh:
- Setting
logging_settingsexclusively onmodule.organization-loggingwhile retainingdepends_on = [module.organization-logging]onmodule.no-compliance-folderandmodule.branch-common-services-folderpreserves regional log storage inheritance from the organization and avoids CMEKkms_key_namerejection ongoogle_logging_folder_settings.default[0]insideIL5andFEDRAMP_HIGHAssured Workloads folders. tests/test_bootstrap_logging_order.py(test_only_the_organization_sets_logging_settings) passes cleanly.- Re-ran the
Python Unit Tests & Code Qualityworkflow job after thetest_generate_id_formatflake addressed in #362, and all CI checks are now green.
aghassemlouei
approved these changes
Oct 26, 2026
Merged
15 of 26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Let the first Stage 0 apply finish under Assured Workloads regimes that enforce CMEK for Logging, such as IL5, by letting the Stage 0 folders inherit the organization logging settings.
The
fast/stages-aw/0-bootstrap/stage sets the samestorage_locationvalue three times: on the organization, on the common services folder, and on the no-compliance folder. The common services folder sits under the Assured Workloads folder. IL5 enforces theconstraints/gcp.restrictNonCmekServicesconstraint forlogging.googleapis.comthere, so the API rejects folder logging settings without a KMS key, and themodules/folder/module has no CMEK input for them.logging_settingsargument from thebranch-common-services-folderandno-compliance-foldermodules in theorganization.tffile.organization-loggingmodule now explains why the folders set no settings of their own.tests/test_bootstrap_logging_order.pyfile checks that only the organization sets the logging settings.No GitHub issue exists for this change. The
stellarCLI work in #306 found it during a lab Stage 0 apply, right after #359 fixed the folder number.Type of Change
Deployment & Compliance Impact
Checklist
Code Quality & Reusability
modules/orfast/stages-aw/can be leveraged for this change.docs/naming-convention.md.Documentation
README.mdof the modified module or blueprint.Security
Testing
Testing Performed
module.branch-common-services-folder.google_logging_folder_settings.default[0]with aconstraints/gcp.restrictNonCmekServicesviolation forlogging.googleapis.com.logging.googleapis.comamong the services that require CMEK.terraform init -backend=falseandterraform validatepass for thefast/stages-aw/0-bootstrap/stage.terraform fmt -checkpasses for the stage.uv run --locked pytestin the repository root passes 109 tests.main.