Repository navigation
fix(cli): ignore deleted folders in the preflight folder check - #356
Merged
aghassemlouei merged 1 commit intoOct 26, 2026
Merged
Conversation
This was referenced Oct 24, 2026
aghassemlouei
approved these changes
Oct 26, 2026
aghassemlouei
left a comment
Member
There was a problem hiding this comment.
Verified locally with pytest, ruff, and pyright. Filtering search_folders to AND state=ACTIVE cleanly prevents 30-day soft-deleted Assured Workloads folders from triggering false-positive preflight collisions while preserving DELETE_REQUESTED project ID checks.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stop the
naming.folderpreflight check from reporting a folder collision for a folder that someone already deleted.The check searches the organization for the
StellarEngine-<prefix>Assured Workloads folder. The search also returned folders in theDELETE_REQUESTEDstate, which keep their display name for 30 days but do not block a new folder with the same name.find_foldersmethod incli/src/stellar_engine/gcp/live.pynow addsstate=ACTIVEto the folder search query.cli/tests/test_live.pychecks the query.No GitHub issue exists for this change. The
stellarCLI work in #306 found it during a lab run.The change needs no README update, because the preflight documentation already describes the check as a search for an existing folder.
Type of Change
Deployment & Compliance Impact
Checklist
Code Quality & Reusability
modules/orfast/stages-aw/can be leveraged for this change.docs/naming-convention.md.Documentation
README.mdof the modified module or blueprint.Security
Testing
Testing Performed
uv run pytestin thecli/project passes 161 tests, including the new query test.ruff format --check,ruff check, andpyrightpass for thecli/project.DELETE_REQUESTEDstate and no active folder of the same name, the Resource Manager search withstate=ACTIVEreturns no folder, and the search withstate=DELETE_REQUESTEDreturns all three.