Repository navigation
fix(stages): harden Stage 2 networking, Stage 3 security, and tooling scripts - #350
Closed
aghassemlouei wants to merge 1 commit into
Closed
aghassemlouei wants to merge 1 commit into
aghassemlouei wants to merge 1 commit into
Conversation
aghassemlouei
requested review from
Calvin-Cheng1,
LanceWray and
mgcarey-google
October 23, 2026 13:23
aghassemlouei
force-pushed
the
fix/stages-2-3-networking-security-and-tools
branch
from
October 26, 2026 17:27
983a117 to
4ed9b30
Compare
… scripts - Fix Stage 2 host_project_ids output, add default hierarchical firewall policy factory data files, remove redundant private.googleapis.com routes, and gate PSC/PSA address and connection resources when psa_ranges is configured - Remove management VPC default internet route and Cloud NAT, parameterize NGFW template region, disable serial console, block project SSH keys, and harden PAN-OS bootstrap crypto and management profiles - Restrict Stage 3 tfvars file permissions to 0600, mark GCS tfvars object content sensitive with CMEK encryption, fix VPC-SC logging project fallback and dry-run active status preservation, and scope dev/prod KMS restricted admins to environment-specific service accounts - Expand sa_lockdown.sh service account coverage with nullglob, relax validation.sh project filter to match stage-specific IaC core naming, replace eval in scripts/destroy.sh with printf -v, harden scripts/restore.sh and tools/create_e2e_sandbox.sh, and update generate-mocks.sh Stage 2a path
aghassemlouei
force-pushed
the
fix/stages-2-3-networking-security-and-tools
branch
from
October 28, 2026 04:09
4ed9b30 to
e259ba2
Compare
Member
Author
|
Rebased onto |
Member
Author
aghassemlouei
deleted the
fix/stages-2-3-networking-security-and-tools
branch
October 28, 2026 04:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hardens Stage 2 (
2-networking-a-fedrampand2-networking-b-il5-ngfw), Stage 3 (3-security), and repository shell scripts:host_project_idsoutput, add default hierarchical firewall policy factory data files (cidrs.yamlandhierarchical-ingress-rules.yaml), referencemodule.env-spoke-projects[each.key].project_idinpsc.tf, and gate PSC/PSA resources whenpsa_rangesis configured.each.value) in2-networking-b-il5-ngfw, disable serial port access, block project-wide SSH keys, and harden PAN-OS bootstrap crypto and management profiles.tfvarsfile permissions to0600, encrypt GCStfvarsobjects with CMEK and mark content sensitive, fix VPC-SC logging project fallback and dry-run active status preservation, and scope dev/prod KMS restricted admins to environment-specific service accounts.sa_lockdown.shservice account coverage withnullglob, updatevalidation.shIaC core project filter, replaceevalinscripts/destroy.shwithprintf -v, hardenscripts/restore.shandtools/create_e2e_sandbox.sh, and fix the Stage 2a path ingenerate-mocks.sh.Type of Change
Deployment & Compliance Impact
AC-3,AC-4,AC-6,CM-6,SC-7,SC-12,SC-28Checklist
Code Quality & Reusability
modules/orfast/stages-aw/can be leveraged for this change.docs/naming-convention.md.Documentation
README.mdof the modified module or blueprint.Security
Testing
Testing Performed
bash tools/lint.shpasses all 10 repository checks (Boilerplate check,Terraform format,Terraform lint,READMEs,Links,FAST Names,Python formatting,Python lint,Blueprint metadata,Version checks).bash tools/run_tests.sh,ruff check ., andruff format --check .pass with zero errors.