Repository navigation
fix(blueprints): return the il5/gke bastion external IP - #343
Merged
Calvin-Cheng1 merged 1 commit intoOct 23, 2026
Merged
Conversation
The bastion_vm_public_ip output read module.bastion-vm.network_interfaces[0].access_config[0].nat_ip, but the compute-vm module has no network_interfaces output. The try() wrapper discarded the resulting error, so the output was always null, even for a VM with an external IP. Read the module's external_ip output instead. It already returns null when the main interface has no NAT, so no try() is needed. The output description drops its parenthetical, and tools/tfdoc.py regenerates the README table. The fedramp-high/gke symlink picks up the change. Fixes google#316.
Calvin-Cheng1
self-requested a review
October 23, 2026 04:07
Calvin-Cheng1
approved these changes
Oct 23, 2026
Merged
18 of 19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
bastion_vm_public_ipoutput of theblueprints/il5/gke/blueprint now returns the bastion VM external IP address that themodules/compute-vm/module reports.module.bastion-vm.network_interfaces[0].access_config[0].nat_ip, but themodules/compute-vm/module declares nonetwork_interfacesoutput.try()wrapper hid the resulting error, so the output was always null, even for a VM with an external IP.external_ipoutput, which already returns null when the main interface has no NAT, so thetry()wrapper is gone.tools/tfdoc.pyscript regenerated the README outputs table.blueprints/fedramp-high/gkepath is a Git120000symlink to../il5/gke, so the fix covers both blueprints.The current blueprint configures the bastion without NAT, so deployed values stay null today. The output now reports a real address as soon as the VM gets an external IP.
Fixes #316
Type of Change
Deployment & Compliance Impact
Checklist
Code Quality & Reusability
modules/orfast/stages-aw/can be leveraged for this change.docs/naming-convention.md.Documentation
README.mdof the modified module or blueprint.Security
Testing
Testing Performed
The fix passes a credential-free mock plan that fails against
main.terraform init -backend=falseandterraform validatein theblueprints/il5/gke/blueprint pass on this branch. Validate also passes onmain, because thetry()wrapper hides the missing module output.tests/verify.tftest.hclfile with mockgoogleandgoogle-betaproviders, placeholder variables, andcommand = planran two cases.bastion-vmmodule withexternal_ip = "203.0.113.10"and asserts thatoutput.bastion_vm_public_ipequals that address.terraform testpasses both cases on this branch. Onmain, the first case fails because the output is null, and the second case passes. The branch commits neither the temporary test file nor the.terraformdirectory and lock file.uv run python tools/check_documentation.py blueprints/il5/gkepasses after the README regeneration.bash tools/lint.shpasses every check except Terraform lint, which fails only becausetflintis not installed locally. The CItflintjob covers it.