Skip to content

fix(gke): enable shielded nodes by default and fix gke-hardened feature key - #341

Merged
Calvin-Cheng1 merged 1 commit into
mainfrom
fix/gke-shielded-nodes
Oct 23, 2026
Merged

Calvin-Cheng1 merged 1 commit into
mainfrom
fix/gke-shielded-nodes

Conversation

@aghassemlouei

Copy link
Copy Markdown
Member

Description

Enables Shielded GKE Nodes by default in modules/gke-cluster-standard and modules/gke-cluster-standard-se (shielded_nodes = optional(bool, true)) and fixes the enable_features attribute key in blueprints/il5/gke-hardened/main.tf from enable_shielded_nodes = true to shielded_nodes = true so Terraform does not drop the setting during object type conversion. This resolves Code Scanning alerts #165 and #169 (GCP-0055).

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Deployment & Compliance Impact

  • Applicable Regimes:
    • US Region Restricted (e.g., Access Policy constraint)
    • FedRAMP Moderate
    • FedRAMP High
    • DoD IL4
    • DoD IL5
    • General / All
  • NIST 800-53r5 Controls: SI-7 (Software, Firmware, and Information Integrity), SC-8 (Transmission Confidentiality and Integrity)

Checklist

Code Quality & Reusability

  • My code adheres to the Maximize Reusability principle. I have not redefined common elements and have reused existing base configurations and modules where possible.
  • I have checked that no existing module or configuration in modules/ or fast/stages-aw/ can be leveraged for this change.
  • My code follows the established naming conventions outlined in docs/naming-convention.md.

Documentation

  • I have updated the README.md of the modified module or blueprint.
  • I have added/updated documentation for inputs (variables) and outputs.

Security

  • My change adheres to GCP security best practices and the principle of least privilege.
  • I have ensured compliance with the targeted regime (FedRAMP Moderate, FedRAMP High, IL4, IL5, etc.).

Testing

  • I have tested my changes locally.
  • I have included details of my testing in this PR.

Testing Performed

  • Ran bash tools/lint.sh (Boilerplate, terraform fmt, tflint across 137 directories, check_documentation.py, check_links.py, check_names.py, ruff, validate_metadata.py, and version checks).
  • Ran bash tools/run_tests.sh (99 Python unit tests, 49 shell unit tests, 6 tflint runner tests, and 58 Python AST checks).

@aghassemlouei aghassemlouei added Bug Something isn't working Framework - FedRAMP High FedRAMP High compliance regime and controls Framework - IL5 DoD Impact Level 5 (IL5) compliance regime and controls Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete Priority - High Critical issues blocking development or users; urgent bugs or core features for release Scope - Blueprint Related to solution blueprints in the blueprints directory Scope - Module Related to reusable Terraform modules in the modules directory Security Something is insecure or can be secured labels Oct 22, 2026
@aghassemlouei
aghassemlouei marked this pull request as ready for review October 23, 2026 00:28
@Calvin-Cheng1
Calvin-Cheng1 merged commit a3c90fe into main Oct 23, 2026
22 checks passed
@Calvin-Cheng1
Calvin-Cheng1 deleted the fix/gke-shielded-nodes branch October 23, 2026 04:06
digitalresistor added a commit to digitalresistor/stellar-engine that referenced this pull request Oct 23, 2026
The il5/gke-hardened blueprint passed node_config.metadata with
block-project-ssh-keys, node_config.machine_type and
node_config.confidential_nodes to the modules/gke-cluster-standard-se
module, whose node_config type declares none of them, so Terraform
discarded them without an error. google#341 already fixed the shielded nodes
key in the same issue.

Move the block-project-ssh-keys metadata and Confidential GKE Nodes onto
the cluster-nodepool module, which already sets the machine type. The
modules/gke-nodepool module gains an optional node_config
confidential_nodes flag that renders the provider confidential_nodes
block with the given value when set, because the module had no way to
enable it.

The default n2d-standard-2 machine type supports Confidential GKE
Nodes; the node_machine_type description now states the requirement.

The provider marks node pool metadata as ForceNew, so Terraform
replaces the cluster-nodepool node pool of existing deployments.

Fixes google#315.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Framework - FedRAMP High FedRAMP High compliance regime and controls Framework - IL5 DoD Impact Level 5 (IL5) compliance regime and controls Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete Priority - High Critical issues blocking development or users; urgent bugs or core features for release Scope - Blueprint Related to solution blueprints in the blueprints directory Scope - Module Related to reusable Terraform modules in the modules directory Security Something is insecure or can be secured

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants