Repository navigation
fix(gke): enable shielded nodes by default and fix gke-hardened feature key - #341
Merged
Merged
Conversation
aghassemlouei
requested review from
Calvin-Cheng1,
LanceWray and
mgcarey-google
October 22, 2026 21:17
aghassemlouei
marked this pull request as ready for review
October 23, 2026 00:28
Calvin-Cheng1
approved these changes
Oct 23, 2026
Merged
digitalresistor
added a commit
to digitalresistor/stellar-engine
that referenced
this pull request
Oct 23, 2026
The il5/gke-hardened blueprint passed node_config.metadata with block-project-ssh-keys, node_config.machine_type and node_config.confidential_nodes to the modules/gke-cluster-standard-se module, whose node_config type declares none of them, so Terraform discarded them without an error. google#341 already fixed the shielded nodes key in the same issue. Move the block-project-ssh-keys metadata and Confidential GKE Nodes onto the cluster-nodepool module, which already sets the machine type. The modules/gke-nodepool module gains an optional node_config confidential_nodes flag that renders the provider confidential_nodes block with the given value when set, because the module had no way to enable it. The default n2d-standard-2 machine type supports Confidential GKE Nodes; the node_machine_type description now states the requirement. The provider marks node pool metadata as ForceNew, so Terraform replaces the cluster-nodepool node pool of existing deployments. Fixes google#315.
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enables Shielded GKE Nodes by default in
modules/gke-cluster-standardandmodules/gke-cluster-standard-se(shielded_nodes = optional(bool, true)) and fixes theenable_featuresattribute key inblueprints/il5/gke-hardened/main.tffromenable_shielded_nodes = truetoshielded_nodes = trueso Terraform does not drop the setting during object type conversion. This resolves Code Scanning alerts#165and#169(GCP-0055).Type of Change
Deployment & Compliance Impact
Checklist
Code Quality & Reusability
modules/orfast/stages-aw/can be leveraged for this change.docs/naming-convention.md.Documentation
README.mdof the modified module or blueprint.Security
Testing
Testing Performed
bash tools/lint.sh(Boilerplate,terraform fmt,tflintacross 137 directories,check_documentation.py,check_links.py,check_names.py,ruff,validate_metadata.py, and version checks).bash tools/run_tests.sh(99 Python unit tests, 49 shell unit tests, 6tflintrunner tests, and 58 Python AST checks).