Skip to content

fix(fast): omit log sink ingress without logging - #340

Merged
aghassemlouei merged 1 commit into
google:mainfrom
huong8373tt-beep:fix/318-conditional-log-sink-ingress-policy
Oct 22, 2026
Merged

aghassemlouei merged 1 commit into
google:mainfrom
huong8373tt-beep:fix/318-conditional-log-sink-ingress-policy

Conversation

@huong8373tt-beep

@huong8373tt-beep huong8373tt-beep commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Description

Fixes #318.

When var.vpc_sc.perimeter_default is configured in fast/stages-aw/3-security/vpc-sc.tf with var.logging = null, local.vpc_sc_perimeter still appended "fast-org-log-sinks" to ingress_policies even though local.vpc_sc_ingress_policies only defines fast-org-log-sinks when var.logging != null. This change gates "fast-org-log-sinks" on var.logging == null ? [] : ["fast-org-log-sinks"].

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Deployment & Compliance Impact

  • Applicable Regimes:
    • US Region Restricted (e.g., Access Policy constraint)
    • FedRAMP Moderate
    • FedRAMP High
    • DoD IL4
    • DoD IL5
    • General / All
  • NIST 800-53r5 Controls: AU-9, SC-7

Checklist

Code Quality & Reusability

  • My code adheres to the Maximize Reusability principle. I have not redefined common elements and have reused existing base configurations and modules where possible.
  • I have checked that no existing module or configuration in modules/ or fast/stages-aw/ can be leveraged for this change.
  • My code follows the established naming conventions outlined in docs/naming-convention.md.

Documentation

  • I have updated the README.md of the modified module or blueprint.
  • I have added/updated documentation for inputs (variables) and outputs.

Security

  • My change adheres to GCP security best practices and the principle of least privilege.
  • I have ensured compliance with the targeted regime (FedRAMP Moderate, FedRAMP High, IL4, IL5, etc.).

Testing

  • I have tested my changes locally.
  • I have included details of my testing in this PR.

Testing Performed

  • Executed bash tools/run_tests.sh and bash tools/lint.sh.
  • Verified with terraform init and terraform plan in fast/stages-aw/3-security that module.vpc-sc[0] plans cleanly both when var.logging = null (omitting fast-org-log-sinks) and when var.logging is populated (including the fast-org-log-sinks ingress policy).

@github-actions github-actions Bot added the Scope - Fast Related to Fabric FAST deployment stages in the fast directory label Oct 22, 2026
@aghassemlouei
aghassemlouei force-pushed the fix/318-conditional-log-sink-ingress-policy branch from 5f65a28 to 122872f Compare October 22, 2026 14:54
@aghassemlouei aghassemlouei added Bug Something isn't working Security Something is insecure or can be secured Priority - High Critical issues blocking development or users; urgent bugs or core features for release Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete labels Oct 22, 2026
@aghassemlouei
aghassemlouei force-pushed the fix/318-conditional-log-sink-ingress-policy branch from 122872f to 5f65a28 Compare October 22, 2026 15:09

@aghassemlouei aghassemlouei left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for guarding the log sink ingress policy when logging is unset in 3-security, @huong8373tt-beep! Confirmed the perimeter plans cleanly both with and without logging configured.

@aghassemlouei
aghassemlouei merged commit d0159cb into google:main Oct 22, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete Priority - High Critical issues blocking development or users; urgent bugs or core features for release Scope - Fast Related to Fabric FAST deployment stages in the fast directory Security Something is insecure or can be secured

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] 3-security: an enabled perimeter fails when the logging variable is unset

2 participants