Repository navigation
fix(fast): omit log sink ingress without logging - #340
Merged
aghassemlouei merged 1 commit intoOct 22, 2026
Merged
aghassemlouei merged 1 commit into
aghassemlouei merged 1 commit into
Conversation
aghassemlouei
force-pushed
the
fix/318-conditional-log-sink-ingress-policy
branch
from
October 22, 2026 14:54
5f65a28 to
122872f
Compare
aghassemlouei
requested review from
Calvin-Cheng1,
LanceWray and
mgcarey-google
October 22, 2026 14:56
aghassemlouei
force-pushed
the
fix/318-conditional-log-sink-ingress-policy
branch
from
October 22, 2026 15:09
122872f to
5f65a28
Compare
aghassemlouei
approved these changes
Oct 22, 2026
aghassemlouei
left a comment
Member
There was a problem hiding this comment.
Thanks for guarding the log sink ingress policy when logging is unset in 3-security, @huong8373tt-beep! Confirmed the perimeter plans cleanly both with and without logging configured.
Merged
18 of 19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #318.
When
var.vpc_sc.perimeter_defaultis configured infast/stages-aw/3-security/vpc-sc.tfwithvar.logging = null,local.vpc_sc_perimeterstill appended"fast-org-log-sinks"toingress_policieseven thoughlocal.vpc_sc_ingress_policiesonly definesfast-org-log-sinkswhenvar.logging != null. This change gates"fast-org-log-sinks"onvar.logging == null ? [] : ["fast-org-log-sinks"].Type of Change
Deployment & Compliance Impact
Checklist
Code Quality & Reusability
modules/orfast/stages-aw/can be leveraged for this change.docs/naming-convention.md.Documentation
README.mdof the modified module or blueprint.Security
Testing
Testing Performed
bash tools/run_tests.shandbash tools/lint.sh.terraform initandterraform planinfast/stages-aw/3-securitythatmodule.vpc-sc[0]plans cleanly both whenvar.logging = null(omittingfast-org-log-sinks) and whenvar.loggingis populated (including thefast-org-log-sinksingress policy).