Repository navigation
style(tests): format test_label_taxonomy.py with ruff - #324
Closed
digitalresistor wants to merge 1 commit into
Closed
digitalresistor wants to merge 1 commit into
digitalresistor wants to merge 1 commit into
Conversation
The file landed in 2-space yapf style after the repository switched to ruff, so ruff check and ruff format --check fail on main.
This was referenced Oct 20, 2026
Member
|
Closing as superseded by #323 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change makes the
python-testsCI job pass onmainagain by formattingtests/test_label_taxonomy.pywith ruff.No issue exists for this change. The failure appeared in the CI run for the #302 merge commit.
tests/test_label_taxonomy.pyin the old 2-space yapf style.main, theruff check .step now fails with anI001unsorted-import error in that file, andruff format --check .would also report it.Merge order
These four pull requests share one merge order. Merge them in this sequence.
ruff checkstep pass onmainagain. Every other pull request needs it for a green CI run.uv.lockfile. Rebase it ontomainafter style(tests): format test_label_taxonomy.py with ruff #324 merges, which drops its copy of the style(tests): format test_label_taxonomy.py with ruff #324 commit.uv.lockfile from build(tools): run the repository tooling on a locked uv Python 3.14 environment #323..git-blame-ignore-revs. It only needs style(tests): format test_label_taxonomy.py with ruff #324 for a green CI run, so it can merge at any point after style(tests): format test_label_taxonomy.py with ruff #324.This pull request is step 1.
Type of Change
Deployment & Compliance Impact
Checklist
Code Quality & Reusability
modules/orfast/stages-aw/can be leveraged for this change.docs/naming-convention.md.Documentation
README.mdof the modified module or blueprint.Security
Testing
Testing Performed
All commands ran locally from the branch with ruff 0.17.1, the version that
tools/requirements.txtpins.ruff check .ruff format --check .pytest tests/test_label_taxonomy.py