Repository navigation
fix(modules): fix health check and backend service configs in net-lb-ext, net-lb-int, and net-lb-proxy-int - #297
Merged
Calvin-Cheng1 merged 1 commit intoOct 21, 2026
Conversation
aghassemlouei
requested review from
Calvin-Cheng1,
LanceWray and
mgcarey-google
October 20, 2026 02:31
aghassemlouei
force-pushed
the
fix/internal-lb-health-check-and-backend-refs
branch
from
October 20, 2026 15:06
ad543ab to
ab57c1e
Compare
Calvin-Cheng1
requested changes
Oct 20, 2026
Calvin-Cheng1
left a comment
Collaborator
There was a problem hiding this comment.
Suggestions here:
modules/net-lb-ext/health-check.tf(lines 66–77 and 92–102): Apply the same health check fix here as inmodules/net-lb-int/health-check.tfby pointinghttp2_health_checktolocal.hc.http2.*instead oflocal.hc.http.*andssl_health_checktolocal.hc.ssl.*instead oflocal.hc.tcp.*(matching upstream Cloud Foundation Fabric). This fixes a null reference crash during Terraform plan/apply when configuring anhttp2orsslhealth check on an external load balancer, sincelocal.hc.httpandlocal.hc.tcparenullwhen another health check protocol is selected.modules/net-lb-proxy-int/main.tf(lines 44–48) andmodules/net-lb-proxy-int/backend-service.tf(line 45): Guardlocal.health_checkinmain.tfwithtry(google_compute_region_health_check.default[0].self_link, null)and sethealth_checks = local.health_check == null ? null : [local.health_check]inbackend-service.tf. Whilemodules/net-lb-proxy-int/variables.tfnow fixesCannot iterate over null valuewhenvar.health_check_config = null, this preventsgoogle_compute_region_health_check.default[0]from failing with an empty tuple index error when health checks are disabled (such as for PSC or Internet NEG backends).modules/net-lb-proxy-int/backend-service.tf(lines 59 and 73–93) andmodules/net-lb-proxy-int/variables.tf(lines 36 and 44–56): Removeconnection_tracking_policy,failover_policy,connection_tracking,failover_config, andbackend.failoverinstead of fixing thear.backend_service_configandlocal.bs_conntrackreferences insideconnection_tracking_policy. This fixes both the undeclared reference errors interraform validateand prevents GCP API errors if a user sets those options, sincenet-lb-proxy-intcreates a proxy load balancer (INTERNAL_MANAGED) and GCP only supports connection tracking and failover policies on passthrough load balancers.
aghassemlouei
force-pushed
the
fix/internal-lb-health-check-and-backend-refs
branch
from
October 20, 2026 22:33
ab57c1e to
c574835
Compare
aghassemlouei
force-pushed
the
fix/internal-lb-health-check-and-backend-refs
branch
from
October 20, 2026 22:57
c574835 to
67ebb92
Compare
aghassemlouei
force-pushed
the
fix/internal-lb-health-check-and-backend-refs
branch
from
October 20, 2026 23:26
67ebb92 to
6f015aa
Compare
aghassemlouei
force-pushed
the
fix/internal-lb-health-check-and-backend-refs
branch
4 times, most recently
from
October 21, 2026 00:31
686a110 to
347ebe0
Compare
Member
Author
|
Thanks for the review @Calvin-Cheng1! All three items are addressed in commit
|
aghassemlouei
force-pushed
the
fix/internal-lb-health-check-and-backend-refs
branch
from
October 21, 2026 02:20
347ebe0 to
fd6883d
Compare
…ext, net-lb-int, and net-lb-proxy-int
aghassemlouei
force-pushed
the
fix/internal-lb-health-check-and-backend-refs
branch
from
October 21, 2026 03:00
fd6883d to
a965ce4
Compare
Calvin-Cheng1
approved these changes
Oct 21, 2026
Calvin-Cheng1
deleted the
fix/internal-lb-health-check-and-backend-refs
branch
October 21, 2026 15:24
Merged
18 of 19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
http2_health_checkandssl_health_checkinmodules/net-lb-ext/health-check.tfandmodules/net-lb-int/health-check.tfto read attributes fromlocal.hc.http2andlocal.hc.sslinstead oflocal.hc.httpandlocal.hc.tcp.local.health_checkinmodules/net-lb-proxy-int/main.tfwithtry(google_compute_region_health_check.default[0].self_link, null)and sethealth_checks = local.health_check == null ? null : [local.health_check]inmodules/net-lb-proxy-int/backend-service.tf, removing unsupportedconnection_tracking_policyandfailover_policyblocks and guarding nullablevar.backend_service_config.backendsandvar.health_check_configvalidations inmodules/net-lb-proxy-int/variables.tf.Type of Change
Deployment & Compliance Impact
Checklist
Code Quality & Reusability
modules/orfast/stages-aw/can be leveraged for this change.docs/naming-convention.md.Documentation
README.mdof the modified module or blueprint.Security
Testing
Testing Performed
bash tools/run_tests.sh(all Python unit tests, shell syntax checks, shell unit tests, and CodeQL AST checks pass) andpython3 tools/check_documentation.py modules/net-lb-ext modules/net-lb-int modules/net-lb-proxy-int.