Repository navigation
fix(spanner-instance): add IAM condition support and database deletion_protection default - #276
aghassemlouei wants to merge 1 commit into
Conversation
|
This will require a major release given the impact that it will have on downstream consumers of the code. |
|
Ready for your review @Calvin-Cheng1! |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces significant updates and refactoring across several modules, including cloud-run-v2, folder, net-lb-int, net-lb-proxy-int, and spanner-instance, to support new features such as GPUs, multi-region settings, Privileged Access Manager (PAM) entitlements, and IAM Deny policies. The review feedback highlights several key improvements: resolving a potential Terraform evaluation error in net-lb-proxy-int when forwarding_rule is null, ensuring consistency in folder by reusing the local.folder_number variable instead of redundant string replacement, and robustly handling the projects/ prefix for KMS Autokey configurations.
fb0885e to
f268c33
Compare
fd13e18 to
82f8799
Compare
82f8799 to
b357c74
Compare
b357c74 to
ec50de7
Compare
ec50de7 to
64db47c
Compare
887a88a to
e24bc5a
Compare
…n_protection default
e24bc5a to
60dcd5d
Compare
|
Closing this PR in favor of #311 ( |
Description
conditionobject definitions tovar.iam_bindingsandvar.iam_bindings_additiveinmodules/spanner-instance/variables.tfto match the existing dynamicconditionblocks inmodules/spanner-instance/iam.tf.deletion_protectiontotrueviacoalesce(each.value.deletion_protection, true)and exposedatabase_dialect,default_time_zone,edition, anddefault_backup_schedule_typeinmodules/spanner-instance/main.tfandmodules/spanner-instance/variables.tf.Type of Change
Deployment & Compliance Impact
Checklist
Code Quality & Reusability
modules/orfast/stages-aw/can be leveraged for this change.docs/naming-convention.md.Documentation
README.mdof the modified module or blueprint.Security
Testing
Testing Performed
bash tools/run_tests.sh(all Python unit tests, shell syntax checks, shell unit tests, and CodeQL AST checks pass) andpython3 tools/check_documentation.py modules/spanner-instance.