Repository navigation
docs: fix DDG stage drift, prefix limit, and README formatting - #266
Merged
Merged
Conversation
aghassemlouei
marked this pull request as ready for review
September 25, 2026 19:55
aghassemlouei
enabled auto-merge (squash)
September 25, 2026 19:55
Calvin-Cheng1
pushed a commit
that referenced
this pull request
Oct 2, 2026
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses documentation formatting and deployment guide drift across
scripts/README.md,README.md,docs/prerequisites.md,docs/ddg.md, anddocs/naming-convention.md:scripts/README.md,README.md,docs/prerequisites.md, anddocs/ddg.md([Feature Request] Add pre-flight OS/shell environment checks and containerized workstation support for Windows #252).docs/ddg.mdso the Stage 2 (2-networking-a-fedramp,2-networking-b-il5-ngfw) and Stage 3 (3-security)billing_overrideinstructions point to each stage's ownterraform.tfvarsrather than1-resman/terraform.tfvars, fixes thexargsfallback command for enabling bootstrap APIs, and updates the Stage 0 Assured Workloads note to reference theconstraints/gcp.restrictServiceUsageerror and theStellarEngine-<prefix>folder ([Documentation] docs/ddg.md: billing_override under three later stages still names 1-resman's tfvars, the enable-services fallback one-liner cannot work, and the Stage 0 Assured Workloads note quotes the wrong error and a folder that does not exist #258).docs/naming-convention.mdto state the 7-characterprefixlimit matching0-bootstrap,1-resman, anddocs/ddg.md([Bug] modules/project and modules/iam-service-account silently truncate over-length IDs instead of failing, and the documented prefix limit of 7 characters now leaves zero margin (naming-convention.md still says 6) #228).Fixes #258
Type of Change
Deployment & Compliance Impact
Checklist
Code Quality & Reusability
modules/orfast/can be leveraged for this change.documentation/naming-convention.md.Documentation
README.mdof the modified module or blueprint.Security
Testing
Testing Performed
Verified markdown structure across
scripts/README.md,README.md,docs/prerequisites.md,docs/ddg.md, anddocs/naming-convention.md, and ranbash tests/scripts/run_shell_tests.shandpytestlocally.