Repository navigation
fix(networking): remove unsupported route_tags on cross-spoke SWP egress routes - #412
Merged
Merged
Conversation
aghassemlouei
marked this pull request as ready for review
November 10, 2026 18:08
Calvin-Cheng1
approved these changes
Nov 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follows up on the #404 review comment with @Calvin-Cheng1 to remove
centralized_egress.route_tagsand itstagsbindings ongoogle_compute_route.hub_swp_egressandgoogle_compute_route.spoke_swp_egressinfast/stages-aw/2-networking-a-fedramp.Both
hub-0and each<env>-spoke-0VPC live in separate VPC spokes fromegress-0, which hosts the centralized Secure Web Proxy internal passthrough Network Load Balancer. Per the Network Connectivity Center static routes requirements, cross-spoke static routes targeting an internal passthrough Network Load Balancer in another VPC spoke cannot carry network tags, so setting a non-emptyroute_tagslist causes route validation and forwarding issues across Network Connectivity Center. Keeping both0.0.0.0/0next_hop_ilbroutes untagged preserves valid cross-spoke centralized egress routing.Fixes # N/A
Type of Change
Deployment & Compliance Impact
Checklist
Code Quality & Reusability
modules/orfast/stages-aw/can be leveraged for this change.docs/naming-convention.md.Documentation
README.mdof the modified module or blueprint.Security
Testing
Testing Performed
python3 -m unittest discover -s tests -p '*stage2*' -vpasses all 8 Stage 2 networking unit tests, including regression assertions confirmingroute_tagsand routetagsare absent fromfast/stages-aw/2-networking-a-fedramp/{variables.tf,egress.tf}.fast/stages-aw/2-networking-a-fedramp/README.mdvariable anchors withtools/tfdoc.py.