Repository navigation
Labels
BugSomething isn't workingSomething isn't workingFramework - FedRAMP HighFedRAMP High compliance regime and controlsFedRAMP High compliance regime and controlsFramework - IL5DoD Impact Level 5 (IL5) compliance regime and controlsDoD Impact Level 5 (IL5) compliance regime and controlsLevel of Effort - LowQuick, well-defined tasks with no unknowns; takes a few hours up to one day to completeQuick, well-defined tasks with no unknowns; takes a few hours up to one day to completePriority - HighCritical issues blocking development or users; urgent bugs or core features for releaseCritical issues blocking development or users; urgent bugs or core features for releaseScope - FastRelated to Fabric FAST deployment stages in the fast directoryRelated to Fabric FAST deployment stages in the fast directorySecuritySomething is insecure or can be securedSomething is insecure or can be secured
Description
Bug Description
Several security and functional defects exist in fast/stages-aw/0-bootstrap and fast/stages-aw/1-resman on main at commit db8271cf.
fast/stages-aw/0-bootstrap/data/custom-constraint-policies/networking.yamldefinescustom.restrictFirewallRangeswithresource.sourceRanges.all(range, range == '0.0.0.0/0'). Using.all()instead of.exists()means a firewall rule is only blocked when every CIDR insourceRangesis0.0.0.0/0, allowing any rule with a second CIDR range to bypass the constraint, and IPv6::/0is not checked.fast/stages-aw/0-bootstrap/data/custom-roles/storage_viewer.yamlincludesstorage.objects.createinside a read-only viewer role.fast/stages-aw/0-bootstrap/checklist.tfand the Stage 1 branch state buckets infast/stages-aw/1-resman/branch-dp.tf,branch-gcve.tf,branch-gke.tf,branch-pf.tf,branch-sandbox.tf, andbranch-teams.tfomitencryption_keyCMEK configuration andforce_destroy = var.force_destroy.fast/stages-aw/1-resman/branch-tenants.tfindexeslocal.tenant_iam[each.value.tenant.name]instead oflocal.tenant_iam[each.key], which fails when tenants span multiple environments. In addition,module.tenant-top-folders-iam,module.tenant-core-folders-iam, andmodule.tenant-self-folders-iamall targetmodule.tenant-top-folders[each.key].idwith authoritativeiambindings for overlapping roles such asroles/owner,roles/cloudasset.owner,roles/compute.xpnAdmin,roles/resourcemanager.folderAdmin,roles/resourcemanager.projectCreator, androles/resourcemanager.tagUser, overwriting one another during apply.fast/stages-aw/0-bootstrap/templates/workflow-gitlab.yamlandfast/stages-aw/1-resman/templates/workflow-gitlab.yamlhardcode0-bootstrap-providers.tfinstead of${tf_providers_files.apply}and${tf_providers_files.plan}, andfast/stages-aw/1-resman/outputs.tfpassesservice_accountsingular instead ofservice_accounts = { apply = ..., plan = ... }.
Expected Behavior
custom.restrictFirewallRangesblocks any ingress firewall rule whereresource.sourceRanges.exists(range, range == '0.0.0.0/0' || range == '::/0').storage_viewer.yamlgrants only read permissions.- Stage 0 checklist and Stage 1 branch state buckets configure CMEK via
encryption_keyand respectvar.force_destroy. branch-tenants.tfindexeslocal.tenant_iam[each.key]and merges overlapping folder IAM role bindings into a single authoritative block per folder.- Stage 0 and Stage 1 GitLab CI workflow templates render the stage-specific apply and plan provider filenames and service account maps.
Additional Context
Tracked under #33. Split out from #349 so each defect can be addressed in focused pull requests.
Metadata
Metadata
Assignees
Labels
BugSomething isn't workingSomething isn't workingFramework - FedRAMP HighFedRAMP High compliance regime and controlsFedRAMP High compliance regime and controlsFramework - IL5DoD Impact Level 5 (IL5) compliance regime and controlsDoD Impact Level 5 (IL5) compliance regime and controlsLevel of Effort - LowQuick, well-defined tasks with no unknowns; takes a few hours up to one day to completeQuick, well-defined tasks with no unknowns; takes a few hours up to one day to completePriority - HighCritical issues blocking development or users; urgent bugs or core features for releaseCritical issues blocking development or users; urgent bugs or core features for releaseScope - FastRelated to Fabric FAST deployment stages in the fast directoryRelated to Fabric FAST deployment stages in the fast directorySecuritySomething is insecure or can be securedSomething is insecure or can be secured
Type
Projects
- StatusShow more project fieldsDone
Activity