Skip to content

[Bug] fast/stages-aw/0-bootstrap, 1-resman: fix custom firewall constraint bypass, state bucket CMEK, and tenant folder IAM #369

Description

@aghassemlouei

Bug Description

Several security and functional defects exist in fast/stages-aw/0-bootstrap and fast/stages-aw/1-resman on main at commit db8271cf.

  1. fast/stages-aw/0-bootstrap/data/custom-constraint-policies/networking.yaml defines custom.restrictFirewallRanges with resource.sourceRanges.all(range, range == '0.0.0.0/0'). Using .all() instead of .exists() means a firewall rule is only blocked when every CIDR in sourceRanges is 0.0.0.0/0, allowing any rule with a second CIDR range to bypass the constraint, and IPv6 ::/0 is not checked.
  2. fast/stages-aw/0-bootstrap/data/custom-roles/storage_viewer.yaml includes storage.objects.create inside a read-only viewer role.
  3. fast/stages-aw/0-bootstrap/checklist.tf and the Stage 1 branch state buckets in fast/stages-aw/1-resman/branch-dp.tf, branch-gcve.tf, branch-gke.tf, branch-pf.tf, branch-sandbox.tf, and branch-teams.tf omit encryption_key CMEK configuration and force_destroy = var.force_destroy.
  4. fast/stages-aw/1-resman/branch-tenants.tf indexes local.tenant_iam[each.value.tenant.name] instead of local.tenant_iam[each.key], which fails when tenants span multiple environments. In addition, module.tenant-top-folders-iam, module.tenant-core-folders-iam, and module.tenant-self-folders-iam all target module.tenant-top-folders[each.key].id with authoritative iam bindings for overlapping roles such as roles/owner, roles/cloudasset.owner, roles/compute.xpnAdmin, roles/resourcemanager.folderAdmin, roles/resourcemanager.projectCreator, and roles/resourcemanager.tagUser, overwriting one another during apply.
  5. fast/stages-aw/0-bootstrap/templates/workflow-gitlab.yaml and fast/stages-aw/1-resman/templates/workflow-gitlab.yaml hardcode 0-bootstrap-providers.tf instead of ${tf_providers_files.apply} and ${tf_providers_files.plan}, and fast/stages-aw/1-resman/outputs.tf passes service_account singular instead of service_accounts = { apply = ..., plan = ... }.

Expected Behavior

  • custom.restrictFirewallRanges blocks any ingress firewall rule where resource.sourceRanges.exists(range, range == '0.0.0.0/0' || range == '::/0').
  • storage_viewer.yaml grants only read permissions.
  • Stage 0 checklist and Stage 1 branch state buckets configure CMEK via encryption_key and respect var.force_destroy.
  • branch-tenants.tf indexes local.tenant_iam[each.key] and merges overlapping folder IAM role bindings into a single authoritative block per folder.
  • Stage 0 and Stage 1 GitLab CI workflow templates render the stage-specific apply and plan provider filenames and service account maps.

Additional Context

Tracked under #33. Split out from #349 so each defect can be addressed in focused pull requests.

Activity

  1. added
    BugSomething isn't working
    SecuritySomething is insecure or can be secured
    Priority - HighCritical issues blocking development or users; urgent bugs or core features for release
    Level of Effort - LowQuick, well-defined tasks with no unknowns; takes a few hours up to one day to complete
    Framework - IL5DoD Impact Level 5 (IL5) compliance regime and controls
    Scope - FastRelated to Fabric FAST deployment stages in the fast directory
    on Oct 28, 2026
  2. moved this from Todo to In Progress in stellar-engineon Oct 28, 2026
  3. added theissue type on Nov 5, 2026
  4. moved this from In Progress to Done in stellar-engineon Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't workingFramework - FedRAMP HighFedRAMP High compliance regime and controlsFramework - IL5DoD Impact Level 5 (IL5) compliance regime and controlsLevel of Effort - LowQuick, well-defined tasks with no unknowns; takes a few hours up to one day to completePriority - HighCritical issues blocking development or users; urgent bugs or core features for releaseScope - FastRelated to Fabric FAST deployment stages in the fast directorySecuritySomething is insecure or can be secured

    Type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions