Repository navigation
Labels
BugSomething isn't workingSomething isn't workingLevel of Effort - LowQuick, well-defined tasks with no unknowns; takes a few hours up to one day to completeQuick, well-defined tasks with no unknowns; takes a few hours up to one day to completePriority - HighCritical issues blocking development or users; urgent bugs or core features for releaseCritical issues blocking development or users; urgent bugs or core features for releaseScope - BlueprintRelated to solution blueprints in the blueprints directoryRelated to solution blueprints in the blueprints directoryScope - ModuleRelated to reusable Terraform modules in the modules directoryRelated to reusable Terraform modules in the modules directorySecuritySomething is insecure or can be securedSomething is insecure or can be secured
Description
Bug Description
The blueprints/third-party-solutions/gitlab/services.tf file passes network_config.connectivity.psa_configs, a list, to the modules/cloudsql-instance module. The module declares psa_config, a single object, so Terraform silently discards the list and the GitLab database has no private services access connection.
Environment and Deployment Context
- Stellar Engine Version/Commit:
mainat commit2b112119e - Deployment Type:
- US Region Restricted (e.g., Access Policy constraint)
- FedRAMP Moderate
- FedRAMP High
- DoD IL4
- DoD IL5
- Stand-alone / Custom
- FAST Stage (if applicable):
- Stage 0 (Bootstrap)
- Stage 1 (Resource Management)
- Stage 2 (Network Creation)
- Stage 3 (Security and Audit)
- Affected Component:
blueprints/third-party-solutions/gitlab,modules/cloudsql-instance - Terraform Version: any; static analysis of the configuration
- GCP Provider Version: any
Steps to Reproduce
- Read
blueprints/third-party-solutions/gitlab/services.tf, lines 37 to 43. - Compare the
network_config.connectivitytype inmodules/cloudsql-instance/variables.tf, which declarespsa_configbut nopsa_configs. - Run
terraform planfor the blueprint and inspectgoogle_sql_database_instancesettings.ip_configuration.private_network.
Expected Behavior
The instance attaches to var.network_config.network_self_link through private services access, so GitLab reaches the database over the VPC.
Actual Behavior
The private network attribute stays unset. With public_ipv4 at its default of false, the instance has no IP address configuration, so the apply fails or GitLab cannot reach the database.
Relevant Logs and Errors
No error appears, because Terraform discards object attributes that a variable type does not declare.
Additional Context
- Replace
psa_configs = [{ private_network = ... }]withpsa_config = { private_network = ... }. - The upstream sync in feat(modules)!: sync Cloud Foundation Fabric modules to v60.0.0 and add sync tooling #311 keeps the same attribute name, so the fix applies before and after it.
- Found while migrating module callers in feat(modules)!: sync Cloud Foundation Fabric modules to v60.0.0 and add sync tooling #311.
Metadata
Metadata
Assignees
Labels
BugSomething isn't workingSomething isn't workingLevel of Effort - LowQuick, well-defined tasks with no unknowns; takes a few hours up to one day to completeQuick, well-defined tasks with no unknowns; takes a few hours up to one day to completePriority - HighCritical issues blocking development or users; urgent bugs or core features for releaseCritical issues blocking development or users; urgent bugs or core features for releaseScope - BlueprintRelated to solution blueprints in the blueprints directoryRelated to solution blueprints in the blueprints directoryScope - ModuleRelated to reusable Terraform modules in the modules directoryRelated to reusable Terraform modules in the modules directorySecuritySomething is insecure or can be securedSomething is insecure or can be secured
Activity