Pycryptodome AuthSigner is incorrect #109

Activity

1. fahhem commented on May 31, 2018

   

   fahhem

   on May 31, 2018

   Contributor

   More actions

   Can you verify it works when you replace the following lines:

   h = SHA256.new(data)
   return pkcs1_15.new(self.rsa_key).sign(h)

   With this line:

   return pkcs1_15.new(self.rsa_key).sign(data)
2. GoobyCorp commented on May 31, 2018

   

   GoobyCorp

   on May 31, 2018

   Last edited by GoobyCorp

   Author

   More actions

   That won't work either, it requires a hasher instance.
3. fahhem commented on May 31, 2018

   

   fahhem

   on May 31, 2018

   Contributor

   More actions

   In other signers it looks like the data comes pre-hashed. Have you tried the code?
4. GoobyCorp commented on May 31, 2018

   

   GoobyCorp

   on May 31, 2018

   Author

   More actions

   If it's prehashed then it's not going to work with pycryptodome without modifications.
5. fahhem commented on May 31, 2018

   

   fahhem

   on May 31, 2018

   Contributor

   More actions

   Do you have any suggestions then? @greateggsgreg added pycryptodome and I assume he tried it out. Did you try anything or is this just theory?
6. GoobyCorp commented on May 31, 2018

   

   GoobyCorp

   on May 31, 2018

   Last edited by GoobyCorp

   Author

   More actions

   I've tested everything I've written, also in the documentation it says the format for the public key being sent is PEM with the header, footer, and newlines removed but from other implementations of ADB this doesn't appear to be the case.