You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please answer these questions before submitting your issue. Thanks!
What version of pprof are you using?
3.2.0
What operating system and processor architecture are you using?
MacOS Ventura 13.4.1 (M1 Chip)
Alpine Linux 16
What did you do?
We run the Cloud Profiler product for Google Cloud in production. We wanted to move some operations into worker threads. These operations are currently ones we would like to profile.
What did you expect to see?
I expected everything to work fine when running our code inside a worker thread, and that pulling in this dependency would be no problem.
What did you see instead?
On Linux: Module did not self-register: /opt/crdt/node_modules/pprof/build/node-v108-linux-x64-musl/pprof.node
On Mac: node_modules/pprof/build/node-v108-darwin-arm64-unknown/pprof.node
I think we can not use pprof in both the main thread and the worker thread, but we can use it in worker thread as follows.
const { Worker, isMainThread } = require('worker_threads');
// Can not be loaded in both the main thread and the worker thread
// const profile = require('pprof');
if (isMainThread) {
new Worker(__filename)
} else {
const profile = require('pprof');
// Removing this will cause a crash
process._stopProfilerIdleNotifier = process._startProfilerIdleNotifier = () => {};
profile.time.profile({
durationMillis: 1000,
});
}
node_modules/pprof/profiles.cc I have changed NODE_MODULE(google_cloud_profiler, InitAll); to NAN_MODULE_WORKER_ENABLED(google_cloud_profiler, InitAll);
cd node_modules/pprof/build && make
as @theanarkh said before calling profile I've added this line process._stopProfilerIdleNotifier = process._startProfilerIdleNotifier = () => {};
Activity
theanarkh commentedon Aug 4, 2023
I think we can not use pprof in both the main thread and the worker thread, but we can use it in worker thread as follows.
dmitryuk commentedon Mar 20, 2024
NODE_MODULE(google_cloud_profiler, InitAll);toNAN_MODULE_WORKER_ENABLED(google_cloud_profiler, InitAll);cd node_modules/pprof/build && makeprofileI've added this lineprocess._stopProfilerIdleNotifier = process._startProfilerIdleNotifier = () => {};Worker profiling totally working now