You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add support for Node 17 and 18. Drop support for Node 10, 12 and 15. #170
changed the title [-]Add support for Node 17 and drop support for Node 15[/-][+]Add support for Node 17 and 18. Drop support for Node 10 and 15.[/+]on Apr 29, 2022
changed the title [-]Add support for Node 17 and 18. Drop support for Node 10 and 15.[/-][+]Add support for Node 17 and 18. Drop support for Node 10, 12 and 15.[/+]on Jun 14, 2022
node-pre-gyp does not currently have maintainers (mapbox/node-pre-gyp#657) and does not support building node 18 binaries on a machine using another version of node (mapbox/node-pre-gyp#647).
Given this, the approach for generating pre-built binaries will need to change to build binaries for Node 18.
I'm going to close this as fixed since we support up to Node 20. The only part of this issue still missing is the pre-built binaries, which I will open a separate issue for.
Activity
[-]Add support for Node 17[/-][+]Add support for Node 17 and drop support for Node 15[/+]amchiclet commentedon Apr 29, 2022
Revisiting this issue now. Updating the title so it matches the current releases of node.
The plan is to update the tests for node 17 and 18 and drop tests for node 10 and 15.
Would also like to note that since we use
source-map, the tests for node 18 will fail until the upstream issue is officially fixed.A workaround is to use the
0.8.0-beta.0version ofsource-map.[-]Add support for Node 17 and drop support for Node 15[/-][+]Add support for Node 17 and 18. Drop support for Node 10 and 15.[/+][-]Add support for Node 17 and 18. Drop support for Node 10 and 15.[/-][+]Add support for Node 17 and 18. Drop support for Node 10, 12 and 15.[/+]nolanmar511 commentedon Jun 22, 2022
node-pre-gypdoes not currently have maintainers (mapbox/node-pre-gyp#657) and does not support building node 18 binaries on a machine using another version of node (mapbox/node-pre-gyp#647).Given this, the approach for generating pre-built binaries will need to change to build binaries for Node 18.
nolanmar511 commentedon Jul 6, 2022
Might be possible to switch to using Node.js's inspector & drop the native portion of this library once LTS for Node 12 has ended.
aabmass commentedon Oct 27, 2022
Should also update the docs here https://cloud.google.com/profiler/docs/profiling-nodejs
pietrodn commentedon Jun 13, 2023
Would it be possible to cut a release to have Node 18 support on the latest stable version? Thanks.
aabmass commentedon Jun 14, 2023
This library works fine on node 18 already. The only issue is we can't supply pre-built binaries. Are you seeing a specific issue @pietrodn ?
pietrodn commentedon Jun 14, 2023
Sorry, I realized that somehow the binary I had in
node_moduleswas built against the wrong Node runtime. A reinstall did the trick.ericwooley commentedon Jul 11, 2023
Should this not have 20 as well now?
franleplant commentedon Oct 25, 2023
would love to see support for node@20
20aabmass commentedon Feb 1, 2024
It should work fine in node 20 already. Please see #273 (comment), for more info.
aabmass commentedon Sep 17, 2024
I'm going to close this as fixed since we support up to Node 20. The only part of this issue still missing is the pre-built binaries, which I will open a separate issue for.