Skip to content

Add support for Node 17 and 18. Drop support for Node 10, 12 and 15. #170

Closed

Description

@nolanmar511

Node 17 will be released on 6/1. Support for Node 15 will end on that day.

We should add tests and pre-built binarys for Node 17, and remove tests and prebuilt binaries for Node 15 then.

Activity

  1. self-assigned this
    on May 26, 2021
  2. changed the title [-]Add support for Node 17[/-] [+]Add support for Node 17 and drop support for Node 15[/+] on May 26, 2021
  3. amchiclet commented on Apr 29, 2022

    @amchiclet
    Contributor

    Revisiting this issue now. Updating the title so it matches the current releases of node.

    The plan is to update the tests for node 17 and 18 and drop tests for node 10 and 15.

    Would also like to note that since we use source-map, the tests for node 18 will fail until the upstream issue is officially fixed.

    A workaround is to use the 0.8.0-beta.0 version of source-map.

  4. changed the title [-]Add support for Node 17 and drop support for Node 15[/-] [+]Add support for Node 17 and 18. Drop support for Node 10 and 15.[/+] on Apr 29, 2022
  5. changed the title [-]Add support for Node 17 and 18. Drop support for Node 10 and 15.[/-] [+]Add support for Node 17 and 18. Drop support for Node 10, 12 and 15.[/+] on Jun 14, 2022
  6. nolanmar511 commented on Jun 22, 2022

    @nolanmar511
    ContributorAuthor

    node-pre-gyp does not currently have maintainers (mapbox/node-pre-gyp#657) and does not support building node 18 binaries on a machine using another version of node (mapbox/node-pre-gyp#647).

    Given this, the approach for generating pre-built binaries will need to change to build binaries for Node 18.

  7. nolanmar511 commented on Jul 6, 2022

    @nolanmar511
    ContributorAuthor

    Might be possible to switch to using Node.js's inspector & drop the native portion of this library once LTS for Node 12 has ended.

  8. self-assigned this
    on Oct 27, 2022
  9. aabmass commented on Oct 27, 2022

    @aabmass
    Member
  10. pietrodn commented on Jun 13, 2023

    @pietrodn

    Would it be possible to cut a release to have Node 18 support on the latest stable version? Thanks.

  11. aabmass commented on Jun 14, 2023

    @aabmass
    Member

    This library works fine on node 18 already. The only issue is we can't supply pre-built binaries. Are you seeing a specific issue @pietrodn ?

  12. pietrodn commented on Jun 14, 2023

    @pietrodn

    Sorry, I realized that somehow the binary I had in node_modules was built against the wrong Node runtime. A reinstall did the trick.

  13. ericwooley commented on Jul 11, 2023

    @ericwooley

    Should this not have 20 as well now?

  14. franleplant commented on Oct 25, 2023

    @franleplant

    would love to see support for node@20 20

  15. aabmass commented on Feb 1, 2024

    @aabmass
    Member

    It should work fine in node 20 already. Please see #273 (comment), for more info.

  16. aabmass commented on Sep 17, 2024

    @aabmass
    Member

    I'm going to close this as fixed since we support up to Node 20. The only part of this issue still missing is the pre-built binaries, which I will open a separate issue for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions