Skip to content

Use detach() instead of clear() in RegistryQuery - #3260

Merged
gbrodman merged 1 commit into
google:masterfrom
gbrodman:registryQueryDetach
Nov 5, 2026
Merged

gbrodman merged 1 commit into
google:masterfrom
gbrodman:registryQueryDetach

Conversation

@gbrodman

@gbrodman gbrodman commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Switch RegistryQuery typed and criteria queries to tm().query() and tm().criteriaQuery(), and replace entityManager.clear() with entityManager.detach(object) in RegistryQuery.detachObject now that HHH-14735 is fixed in Hibernate.


This change is Reviewable

Switch RegistryQuery typed and criteria queries to tm().query() and tm().criteriaQuery(), and replace entityManager.clear() with entityManager.detach(object) in RegistryQuery.detachObject now that HHH-14735 is fixed in Hibernate.
@gbrodman
gbrodman requested a review from weiminyu November 5, 2026 18:09

@weiminyu weiminyu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weiminyu reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on gbrodman).

@gbrodman
gbrodman added this pull request to the merge queue Nov 5, 2026
Merged via the queue into google:master with commit 27efddc Nov 5, 2026
16 checks passed
@gbrodman
gbrodman deleted the registryQueryDetach branch November 5, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants